New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fromString(): qualifiers extracted as string, constructor expects object #7

Closed

mscudlik opened this issue May 8, 2020 · 0 comments

Contributor

mscudlik commented May 8, 2020

in fromString(), the qualifiers are extracted using query(), which returns the querystring

https://github.com/package-url/packageurl-js/blob/master/index.js#L109

afterwards, a new instance is created, but the constructor expects the qualifiers to be a (key/value) object:

https://github.com/package-url/packageurl-js/blob/master/index.js#L42

This was referenced May 14, 2020

added further tests #9

Closed

fixes #5 fixes #7 #10

Closed

steven-esser closed this as completed in

d1a49b3

satanshiro pushed a commit to satanshiro/packageurl-js that referenced this issue


          fixes package-url#5 fixes package-url#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment