feat: Add enum-like static readonly property KnownQualifierNames to reflect known qualifier names
#34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkowalleck
changed the title
KnownQualifierNames to reflect known qualifier names
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
|
Hello @steven-esser , could you have a review on this? |
steven-esser
approved these changes
Sep 7, 2022
satanshiro
pushed a commit
to satanshiro/packageurl-js
that referenced
this pull request
Oct 30, 2023
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add enum-like static readonly property
KnownQualifierNamesto reflect known qualifier namesas defined by https://github.com/package-url/purl-spec/blob/master/PURL-SPECIFICATION.rst#known-qualifiers-keyvalue-pairs
The implementation uses a readonly(frozen) dictionary(object),
because the version ob JavaScript this library was targeting(node 10 according to
.travis.yml) did not support nativve language-levelenum.The usage, responsibility and capabilities are clearly shown in the new unit tests.