Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console scripts compatible Linux/Windows #17

Merged
merged 6 commits into from
Apr 28, 2016

Conversation

tantale
Copy link

@tantale tantale commented Apr 28, 2016

Instead of using scripts for artifact and repo commands, on can use console_script.

> tree /F Scripts
SCRIPTS
    artifact-script.py
    artifact.exe
    artifact.exe.manifest
    [...]
    repo-script.py
    repo.exe
    repo.exe.manifest
    [...]

This works perfectly on Windows:

> artifact --help
usage: artifact-script.py [-h] [-D]
                          {upload,delete,get-metadata,set-metadata,resolve}
                          ...

A command line tool for working with artifacts

positional arguments:
  {upload,delete,get-metadata,set-metadata,resolve}
    upload              Uploads an artifact to repository, can detect name and
                        version from filename
    delete              Deletes an artifact from repository
    get-metadata        Prints artifact's metadata
    set-metadata        Sets artifact's metadata
    resolve             Resolves artifacts' URLs

optional arguments:
  -h, --help            show this help message and exit
  -D, --debug           Print lots of debugging information

I all fix minor problems in setup.py.

@stardust85
Copy link
Member

Awesome work! And the first pull request :) I relly do appreciate it. Once merged, you'll be always recognized as the first contributor to this project 👍

To be honest, I have never tested it on Windows, so I'm glad that someone did it.

Regarding the content: it looks like lot of improvements. Unfortunately tests for py33 and py34 are were failing after your change. I am was not sure, which of that 10 commits broke the tests.

It is easy to enable travis in your fork, so you'll see the build results for each of your commits.

You fixed the py3x builds faster than I finished this comment! 👍 Amazing work!

Gonna merge it :) Regarding releasing a new version, I will release it immediately after fixing #16, which I expect to happen in less than a week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants