Add BGPSessions.Update method. #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctreatma
requested changes
Mar 16, 2023
There was a problem hiding this comment.
@lukasz-drozdz-codilime this looks good. In order to pass the DCO check, could you sign the commit? You can do that by running the following command to sign the existing commit, and then force-pushing your branch to update the PR:
git commit --amend --no-edit -s
Signed-off-by: Lukasz Drozdz <lukasz.drozdz@codilime.com>
lukasz-drozdz-codilime
force-pushed
the
Add-Bgp-Sessions-Update-method-with-PUT
branch
from
b7aa3e2
to
99550a4
Compare
|
Done. Could you take a look @ctreatma ? |
ctreatma
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
packngois missing the ability to update the BGP session via thePUT /bgp/sessions/{id}endpoint.This PR adds that via the
Updatemethod.Please help me get this merged. I'm open for suggestions.