Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding collaborators to projects #216

Closed
3 tasks
lachmanfrantisek opened this issue Sep 20, 2019 · 9 comments · Fixed by #376
Closed
3 tasks

Adding collaborators to projects #216

lachmanfrantisek opened this issue Sep 20, 2019 · 9 comments · Fixed by #376
Assignees
Labels
area/github Related to GitHub implementation. area/gitlab Related to GitLab implementation. good-first-issue Good for newcomers. kind/feature New feature or a request for enhancement. low-prio Low priority. pagure Related to Pagure implementation.

Comments

@lachmanfrantisek
Copy link
Member

  • Add the add_to_collaborators method to abstract.GitProject. (And raise NotImplementedError.)
  • Implement the method for all forges (GitHub, GitLab, Pagure).
  • Add tests for this method.

Documentation:

@lachmanfrantisek lachmanfrantisek added kind/feature New feature or a request for enhancement. good-first-issue Good for newcomers. area/github Related to GitHub implementation. area/gitlab Related to GitLab implementation. pagure Related to Pagure implementation. low-prio Low priority. triaged This issue was already processed by the team. labels Sep 20, 2019
@lachmanfrantisek lachmanfrantisek added the Hacktoberfest Participate in https://hacktoberfest.digitalocean.com label Oct 3, 2019
@lachmanfrantisek
Copy link
Member Author

Should be resolved by #244

@lachmanfrantisek lachmanfrantisek removed triaged This issue was already processed by the team. Hacktoberfest Participate in https://hacktoberfest.digitalocean.com labels Nov 1, 2019
@stale
Copy link

stale bot commented Jan 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.
We are doing this to be sure that the issue is still relevant. Anyone can comment to remove the stale state. (The issues marked with pinned, security, bug or EPIC label
are not considered stale.)

@stale stale bot added the stale Is the issue still valid? label Jan 3, 2020
@lachmanfrantisek
Copy link
Member Author

Yes, I still want it because of my project based on OGR.

@stale stale bot removed the stale Is the issue still valid? label Jan 3, 2020
@mfocko
Copy link
Member

mfocko commented Jan 17, 2020

few things regarding implementation

  • GitHub

    • only for organizations: pull, push, admin - using the default?
  • GitLab

    • access_level what should be default?
      10 => Guest access
      20 => Reporter access
      30 => Developer access
      40 => Maintainer access
      50 => Owner access # Only valid for groups
      
  • Pagure

    • none (removes), ticket, commit, admin - default?

Probably would be good idea to set defaults and keep optional parameter?

@lachmanfrantisek
Copy link
Member Author

lachmanfrantisek commented Feb 14, 2020

* only for organizations: `pull`, `push`, `admin` - **using the default?**

You can add collaborators for the project as well:

Screenshot from 2020-02-14 08-56-45

Screenshot from 2020-02-14 08-58-46

@shreyaspapi
Copy link
Contributor

Hey if this isn't solved yet, Can I give it a try?

@lachmanfrantisek
Copy link
Member Author

Hey if this isn't solved yet, Can I give it a try?

@shreyaspapi Yes, that would be nice. I hope you can find some abstraction that will work for all three implementations.

@shreyaspapi
Copy link
Contributor

shreyaspapi commented Apr 6, 2020

Hey if this isn't solved yet, Can I give it a try?

@shreyaspapi Yes, that would be nice. I hope you can find some abstraction that will work for all three implementations.

Access level can be generalized for the function add_to_collaborators

  • Github
    • permission – string ‘pull’, ‘push’ or ‘admin’ mentioned in pygithub
    • The v3 of github api which pygithub uses, states - The permission to grant the collaborator. Only valid on organization-owned repositories. reference
10 => Pull
20 => Triage
30 => Push
40 => Admin
50 => Maintain 
      
  • Gitlab
    • I can see it is equivalent to github
10 => Guest access
20 => Reporter access
30 => Developer access
40 => Maintainer access
50 => Owner access # Only valid for groups
ticket
commit
admin
  • So this can be done Equivalent to github and gitlab
10 => ticket
20 => ticket
30 => commit
40 => commit
50 => admin

Is there anything else that I missed?

@lachmanfrantisek
Copy link
Member Author

lachmanfrantisek commented Apr 6, 2020

@mfocko you may take a look..;)

@shreyaspapi Yes, GitHub and GitLab look good and the mapping in Pagure is reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github Related to GitHub implementation. area/gitlab Related to GitLab implementation. good-first-issue Good for newcomers. kind/feature New feature or a request for enhancement. low-prio Low priority. pagure Related to Pagure implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants