load service config only once #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes packit#153 Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
|
Build failed.
|
jpopelka
approved these changes
Jan 9, 2020
`make check_in_container` can remove the current working directory w/o this patch Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
|
locally service tests now |
|
Build failed.
|
|
I don't have the patience to deal with requre tests right now. |
jpopelka
reviewed
Jan 15, 2020
|
|
||
| logger = logging.getLogger("packit_service") | ||
| # no need to thank me, just buy me a beer | ||
| logger.debug(f"URL map = {application.url_map}") |
There was a problem hiding this comment.
For some strange reason there's [wsgi:error] in the output:
[Wed Jan 15 08:09:54.088320 2020] [wsgi:error] [pid 19:tid 140426144958208] 08:09:54.088 app.py DEBUG URL map = Map([<Rule '/api/testing-farm/results' (OPTIONS, POST) -> api.testing-farm_testing_farm_results>,
[Wed Jan 15 08:09:54.088354 2020] [wsgi:error] [pid 19:tid 140426144958208] <Rule '/api/webhooks/github' (OPTIONS, POST) -> api.webhooks_github_webhook>,
There was a problem hiding this comment.
I'd say that everything printed by the wsgi app is printed as errors, which is really weird; maybe it can be confiigured in the httpd config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #153