Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sentry integration for service #458

Merged
merged 1 commit into from Mar 6, 2020
Merged

Sentry integration for service #458

merged 1 commit into from Mar 6, 2020

Conversation

lachmanfrantisek
Copy link
Member

@lachmanfrantisek lachmanfrantisek force-pushed the sentry-integration-for-service branch 2 times, most recently from 6eb4755 to ac73d24 Compare March 6, 2020 08:41
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

csomh
csomh approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@csomh csomh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

packit_service/sentry_integration.py
integrations = []

if celery_integration:
# https://docs.sentry.io/platforms/python/celery/
Copy link
Contributor

@csomh csomh Mar 6, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These URLs are very well placed. Thanks! 👨‍🎤

@lachmanfrantisek
Use sentry for service and add other integrations
8d76c5a 
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
@lachmanfrantisek lachmanfrantisek added the mergeit When set, zuul wil gate and merge the PR. label Mar 6, 2020
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 57745a5 into packit:master Mar 6, 2020
@lachmanfrantisek lachmanfrantisek deleted the sentry-integration-for-service branch March 6, 2020 11:55
@lachmanfrantisek lachmanfrantisek mentioned this pull request Mar 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpopelka jpopelka jpopelka approved these changes

@csomh csomh csomh approved these changes

Assignees
No one assigned
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sentry integrations (update and add new)
3 participants
@lachmanfrantisek @jpopelka @csomh