Refactor the LocalProject

[lachmanfrantisek]

Resolves #178

[phracek]

Do we really need so many functions? Are we using all of them?

[lachmanfrantisek]

Currently, not all of them, but I would like to compute as much as we can, so it can be useful in other projects as well.

[phracek]

It is read a bit more, but I would like to see, what part is called in such cases.
I don't see a reference from CLI and I would like to see it.
But It is maybe more complicated.

[phracek]

What about to add there use case when it is called? like LocalProject(git_url, git_service=).
Or maybe even what command use it like propose-update uses two of them.

[TomasTomecek]

I don't understand. If you want to see how the class is being utilized, just open pyčarm and press alt+f7 and that's your most up-to-date answer.

[jpopelka]

alt+f7 is doing some funny window resizing in my case. What action do you have in mind?

[lachmanfrantisek]

I don't see a reference from CLI and I would like to see it.

Sorry, I do not understand what you want. (This class differs the one defining the CLI parameter type)

[phracek]

LGTM

[lachmanfrantisek]

I would like to improve tests as well. Please, wait for that.

[TomasTomecek]

Franto, I understand that you want to support as many use cases as possible; what I'd like to see here personally, is to scope the functionality down: look at how we are using it and only support that: to have a few class methods which accept only 2-3 arguments and would be able to return full instance of local_project; WDYT?

[TomasTomecek]

how about we removed this parameter and performed the check in a dedicated function? then we could pass the path or url to LocalProject

[lachmanfrantisek]

In this case, we need to check this in multiple places. (All CLI functions.)

[lachmanfrantisek]

Franto, I understand that you want to support as many use cases as possible; what I'd like to see here personally, is to scope the functionality down: look at how we are using it and only support that: to have a few class methods which accept only 2-3 arguments and would be able to return full instance of local_project; WDYT?

Current usecases:

1. We know git_url and need working_dir and (cloned) git_repo.
2. We know working_dir+git_service and need git_repo+git_project(And also namespace+name)
3. We know git_url+git_service and need working_dir, (cloned) git_repo and git_project. (And also namespace+name).

For all of them, you can specify branch and there are multiple places, where you do not know if you have git_url or working_dir.

We can probably:

• remove git_url and working_dir and set only path_or_url. (But why, when Explicit is better than implicit.)
• remove offline -- it's not used, but can be usefull for dry-run/offline mode ?

I do not think we can remove any other attribute, since we need to calculate it anyway.

I am not sure I got the benefit of multiple class methods.

Personally, I would like to move the class to ogr, where the general sollution makes more sense.

[lachmanfrantisek]

I'll send a little improved version with tests.

edit: I'll send tests later.

[lachmanfrantisek]

Current usecases:
:

I've made a test for each call of LocalProject.