ogr mock support for packit tests with unittest classes #310

jscotka · 2019-05-07T14:00:55Z

replaces: #303

tested by command: PYTHONPATH=. pytest-3 -v tests/integration_ogr_mock/ with version of ogr what support it.

Update:
with local run tests works as charm.

via make check locally
- 2 tests fails because of missing bodhi package
- 1 test failed because there were mentioned libpaguire dependency, what dowloads latest instead lower what is mentioned in ogr deps

packit-as-a-service · 2019-05-07T14:08:50Z

Congratulations! The build has finished successfully. 🍾

You can install the built RPMs by following these steps:

sudo yum install -y dnf-plugins-core on RHEL 8
sudo dnf install -y dnf-plugins-core on Fedora
dnf copr enable packit/packit-service-packit-310
And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

packit-as-a-service · 2019-05-07T14:29:25Z

Congratulations! The build has finished successfully. 🍾

You can install the built RPMs by following these steps:

sudo yum install -y dnf-plugins-core on RHEL 8
sudo dnf install -y dnf-plugins-core on Fedora
dnf copr enable packit/packit-service-packit-310
And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

TomasTomecek

design LGTM

TomasTomecek · 2019-05-07T14:37:31Z

tests/integration_ogr_mock/test_propose_update.py

+
+
+class ProposeUpdate(PackitUnittestOgr):
+    datafile_github = "TestPropose_github.yaml"


these could be generated in the end, right? something like : TEST_DATA_TOP_DIR / test_file_name / test_class_name + ".yaml"

@TomasTomecek you suggestion is to create trere another subdirectory for each "test file" and inside this have files for each testclass?
it is stored in tearDown function so it dumps data after every test.

update: adapted your suggestion and removed manual class name files handling

packit-as-a-service · 2019-05-09T09:28:12Z

Congratulations! The build has finished successfully. 🍾

You can install the built RPMs by following these steps:

sudo yum install -y dnf-plugins-core on RHEL 8
sudo dnf install -y dnf-plugins-core on Fedora
dnf copr enable packit/packit-service-packit-310
And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

jpopelka · 2019-05-14T10:22:55Z

ogr 0.3.0 has been released. Let's re-run the tests.

jpopelka · 2019-05-14T10:30:09Z

@jscotka please rebase to re-run the tests, thanks

packit-as-a-service · 2019-05-14T12:44:42Z

Congratulations! The build has finished successfully. 🍾

You can install the built RPMs by following these steps:

sudo yum install -y dnf-plugins-core on RHEL 8
sudo dnf install -y dnf-plugins-core on Fedora
dnf copr enable packit/packit-service-packit-310
And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

packit-as-a-service · 2019-05-15T07:51:55Z

Congratulations! The build has finished successfully. 🍾

You can install the built RPMs by following these steps:

sudo yum install -y dnf-plugins-core on RHEL 8
sudo dnf install -y dnf-plugins-core on Fedora
dnf copr enable packit/packit-service-packit-310
And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

packit-as-a-service · 2019-05-15T08:24:09Z

Congratulations! The build has finished successfully. 🍾

You can install the built RPMs by following these steps:

sudo yum install -y dnf-plugins-core on RHEL 8
sudo dnf install -y dnf-plugins-core on Fedora
dnf copr enable packit/packit-service-packit-310
And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

packit-as-a-service · 2019-05-15T08:45:38Z

Congratulations! The build has finished successfully. 🍾

You can install the built RPMs by following these steps:

sudo yum install -y dnf-plugins-core on RHEL 8
sudo dnf install -y dnf-plugins-core on Fedora
dnf copr enable packit/packit-service-packit-310
And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

packit-as-a-service · 2019-06-26T10:19:07Z

There was an error while creating a SRPM.

Output:

error: Bad source: /sandcastle/packitos-0.4.2.dev86+g5e51f33.tar.gz: No such file or directory

Return code: 1

packit-as-a-service · 2019-06-26T12:39:23Z

There was an error while creating a SRPM.

Output:

error: Bad source: /sandcastle/packitos-0.4.2.dev87+g92ed0a7.tar.gz: No such file or directory

Return code: 1

packit-as-a-service · 2019-06-26T13:16:56Z

There was an error while creating a SRPM.

Output:

error: Bad source: /sandcastle/packitos-0.4.2.dev88+g3e8e15f.tar.gz: No such file or directory

Return code: 1

packit-as-a-service · 2019-06-26T13:19:53Z

There was an error while creating a SRPM.

Output:

error: Bad source: /sandcastle/packitos-0.4.2.dev81+gb8c7e51.tar.gz: No such file or directory

Return code: 1

packit-as-a-service · 2019-06-26T13:36:32Z

There was an error while creating a SRPM.

Output:

error: Bad source: /sandcastle/packitos-0.4.2.dev81+gd2b96e5.tar.gz: No such file or directory

Return code: 1

packit-as-a-service · 2019-06-27T06:47:12Z

There was an error while creating a SRPM.

Output:

error: Bad source: /sandcastle/packitos-0.4.2.dev81+g0c4c0fa.tar.gz: No such file or directory

Return code: 1

packit-as-a-service · 2019-06-27T07:01:33Z

There was an error while creating a SRPM.

Output:

error: Bad source: /sandcastle/packitos-0.4.2.dev81+ge06083c.tar.gz: No such file or directory

Return code: 1

lachmanfrantisek

Please, try to use the current master version of OGR if it is possible.

If not, I'll create a follow-up for that...

packit-as-a-service · 2019-06-27T14:23:23Z

There was an error while creating a SRPM.

Output:

error: Bad source: ./packitos-0.4.2.dev81+ge06083c.tar.gz: No such file or directory

Return code: 1

packit-as-a-service · 2019-06-27T14:46:51Z

There was an error while creating a SRPM.

Output:

error: Bad source: ./packitos-0.4.2.dev81+ge06083c.tar.gz: No such file or directory

Return code: 1

TomasTomecek · 2019-06-27T15:14:17Z

I'm trying to fix the issue so I'm using this PR for testing, please don't mind packit's comments

jscotka · 2019-06-28T08:04:07Z

Please, try to use the current master version of OGR if it is possible.

If not, I'll create a follow-up for that...

It is not possible to do it without not nice workarounds.

packit-as-a-service · 2019-06-28T08:20:39Z

Congratulations! The build has finished successfully. 🍾

You can install the built RPMs by following these steps:

sudo yum install -y dnf-plugins-core on RHEL 8
sudo dnf install -y dnf-plugins-core on Fedora
dnf copr enable packit/packit-service-packit-310
And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

jscotka · 2019-06-28T08:29:30Z

I've force pushed after rebase bad data, need to do it again from proper computer

move status from base test class to status test adapt PR suggestion for datafile path location for test classes

jscotka · 2019-06-28T09:55:05Z

rebased to proper branch data

TomasTomecek reviewed May 7, 2019

View reviewed changes

jscotka force-pushed the ogr_mock branch from 622811c to 862204e Compare May 14, 2019 12:27

jscotka force-pushed the ogr_mock branch from 862204e to fddcf4d Compare May 15, 2019 07:45

jscotka force-pushed the ogr_mock branch from 73d3e2a to 001d459 Compare June 10, 2019 13:24

jscotka force-pushed the ogr_mock branch from 001d459 to f018451 Compare June 26, 2019 09:47

jscotka force-pushed the ogr_mock branch from 3e8e15f to b8c7e51 Compare June 26, 2019 13:11

jscotka force-pushed the ogr_mock branch from b8c7e51 to d2b96e5 Compare June 26, 2019 13:27

jscotka force-pushed the ogr_mock branch from d2b96e5 to 0c4c0fa Compare June 27, 2019 06:44

jscotka force-pushed the ogr_mock branch from 0c4c0fa to e06083c Compare June 27, 2019 06:59

jpopelka approved these changes Jun 27, 2019

View reviewed changes

lachmanfrantisek reviewed Jun 27, 2019

View reviewed changes

jscotka force-pushed the ogr_mock branch from e06083c to 7b51011 Compare June 28, 2019 08:13

ogr mock support for packit tests with unittest classes

bbe00c1

move status from base test class to status test adapt PR suggestion for datafile path location for test classes

jscotka force-pushed the ogr_mock branch from 7b51011 to bbe00c1 Compare June 28, 2019 09:28

jscotka merged commit c92acc4 into packit:master Jun 28, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ogr mock support for packit tests with unittest classes #310

ogr mock support for packit tests with unittest classes #310

jscotka commented May 7, 2019 •

edited

packit-as-a-service bot commented May 7, 2019

packit-as-a-service bot commented May 7, 2019

TomasTomecek left a comment

TomasTomecek May 7, 2019

jscotka May 9, 2019 •

edited

packit-as-a-service bot commented May 9, 2019

jpopelka commented May 14, 2019 •

edited

jpopelka commented May 14, 2019

packit-as-a-service bot commented May 14, 2019

packit-as-a-service bot commented May 15, 2019

packit-as-a-service bot commented May 15, 2019

packit-as-a-service bot commented May 15, 2019

packit-as-a-service bot commented Jun 26, 2019

packit-as-a-service bot commented Jun 26, 2019

packit-as-a-service bot commented Jun 26, 2019

packit-as-a-service bot commented Jun 26, 2019

packit-as-a-service bot commented Jun 26, 2019

packit-as-a-service bot commented Jun 27, 2019

packit-as-a-service bot commented Jun 27, 2019

lachmanfrantisek left a comment

packit-as-a-service bot commented Jun 27, 2019

packit-as-a-service bot commented Jun 27, 2019

TomasTomecek commented Jun 27, 2019

jscotka commented Jun 28, 2019

packit-as-a-service bot commented Jun 28, 2019

jscotka commented Jun 28, 2019

jscotka commented Jun 28, 2019



		class ProposeUpdate(PackitUnittestOgr):
		datafile_github = "TestPropose_github.yaml"

ogr mock support for packit tests with unittest classes #310

ogr mock support for packit tests with unittest classes #310

Conversation

jscotka commented May 7, 2019 • edited

packit-as-a-service bot commented May 7, 2019

packit-as-a-service bot commented May 7, 2019

TomasTomecek left a comment

Choose a reason for hiding this comment

TomasTomecek May 7, 2019

Choose a reason for hiding this comment

jscotka May 9, 2019 • edited

Choose a reason for hiding this comment

packit-as-a-service bot commented May 9, 2019

jpopelka commented May 14, 2019 • edited

jpopelka commented May 14, 2019

packit-as-a-service bot commented May 14, 2019

packit-as-a-service bot commented May 15, 2019

packit-as-a-service bot commented May 15, 2019

packit-as-a-service bot commented May 15, 2019

packit-as-a-service bot commented Jun 26, 2019

packit-as-a-service bot commented Jun 26, 2019

packit-as-a-service bot commented Jun 26, 2019

packit-as-a-service bot commented Jun 26, 2019

packit-as-a-service bot commented Jun 26, 2019

packit-as-a-service bot commented Jun 27, 2019

packit-as-a-service bot commented Jun 27, 2019

lachmanfrantisek left a comment

Choose a reason for hiding this comment

packit-as-a-service bot commented Jun 27, 2019

packit-as-a-service bot commented Jun 27, 2019

TomasTomecek commented Jun 27, 2019

jscotka commented Jun 28, 2019

packit-as-a-service bot commented Jun 28, 2019

jscotka commented Jun 28, 2019

jscotka commented Jun 28, 2019

jscotka commented May 7, 2019 •

edited

jscotka May 9, 2019 •

edited

jpopelka commented May 14, 2019 •

edited