Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of the srpm prepare #646

Merged
merged 2 commits into from Jan 6, 2020
Merged

Refactoring of the srpm prepare #646

merged 2 commits into from Jan 6, 2020

Conversation

lachmanfrantisek
Copy link
Member

  • Refactor the preparation of the SRPM build.
  • I am preparing the code for some changes related to the multiple sources and pathes.

@lachmanfrantisek
Refactor the preparation of the SRPM build
4f2f369 
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

TomasTomecek
TomasTomecek reviewed Jan 6, 2020
View reviewed changes
Copy link
Member

@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one tiny nit

packit/local_project.py Outdated Show resolved Hide resolved
@lachmanfrantisek
Better name for LocalProject.commit and another usecase for it
54e12f9 
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@lachmanfrantisek
Copy link
Member Author

@TomasTomecek fixed, PTAL

@lachmanfrantisek
Copy link
Member Author

/packit build

@packit-as-a-service
Copy link

Congratulations! The build has finished successfully. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/packit-service-packit-646
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@TomasTomecek TomasTomecek added the mergeit When set, zuul wil gate and merge the PR. label Jan 6, 2020
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit e2d07df into packit:master Jan 6, 2020
@lachmanfrantisek lachmanfrantisek deleted the refactoring-of-the-srpm-prepare branch January 6, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasTomecek TomasTomecek TomasTomecek approved these changes

Assignees
No one assigned
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lachmanfrantisek @TomasTomecek