Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of the srpm prepare #646

Conversation

@lachmanfrantisek
Copy link
Member

lachmanfrantisek commented Jan 6, 2020

  • Refactor the preparation of the SRPM build.
  • I am preparing the code for some changes related to the multiple sources and pathes.
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Jan 6, 2020

Build succeeded.

Copy link
Contributor

TomasTomecek left a comment

LGTM, just one tiny nit

packit/local_project.py Outdated Show resolved Hide resolved
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Jan 6, 2020

Build succeeded.

@lachmanfrantisek

This comment has been minimized.

Copy link
Member Author

lachmanfrantisek commented Jan 6, 2020

@TomasTomecek fixed, PTAL

@lachmanfrantisek

This comment has been minimized.

Copy link
Member Author

lachmanfrantisek commented Jan 6, 2020

/packit build

@packit-as-a-service

This comment has been minimized.

Copy link

packit-as-a-service bot commented Jan 6, 2020

Congratulations! The build has finished successfully. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/packit-service-packit-646
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@TomasTomecek TomasTomecek added the mergeit label Jan 6, 2020
@softwarefactory-project-zuul

This comment has been minimized.

Copy link
Contributor

softwarefactory-project-zuul bot commented Jan 6, 2020

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit e2d07df into packit-service:master Jan 6, 2020
9 of 11 checks passed
9 of 11 checks passed
packit/rpm-build-fedora-31-x86_64 RPM build has started...
Details
packit/testing-farm-fedora-rawhide-x86_64 Tests are running ...
Details
LGTM analysis: Python No new or fixed alerts
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
local/check check status: success
Details
local/gate gate status: success
Details
packit/rpm-build-fedora-30-x86_64 RPMs were built successfully.
Details
packit/rpm-build-fedora-rawhide-x86_64 RPMs were built successfully.
Details
packit/srpm-build SRPM was built successfully.
Details
packit/testing-farm-fedora-30-x86_64 All tests passed
Details
packit/testing-farm-fedora-31-x86_64 All tests passed
Details
@lachmanfrantisek lachmanfrantisek deleted the lachmanfrantisek:refactoring-of-the-srpm-prepare branch Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.