SPIKE: try VCRpy #785
SPIKE: try VCRpy #785
Conversation
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
|
Build failed.
|
| # if pagure_token is not set and we're recording, we'll get a token failure, | ||
| # but that's expected so no need to take care of it |
There was a problem hiding this comment.
There is no way how to check the mode? It can cause misleading messages in the CI.
There was a problem hiding this comment.
the only error messages I got was that token is not valid - pretty clear
when you tamper with the call stack, you will always get misleading error messages
There was a problem hiding this comment.
It will be funny with GitHub when you randomly receive API limit errors since it works also unauthenticated.
I don't say it's a big problem, but I already need to describe this problem to various contributors and sometimes also people from the team was confused. (The warnings from API are missing important info -- you need to set a specific env. var. to fix that.)
| filter_headers=["Authorization", "Cookie"], | ||
| before_record_response=drop_sensitive_response_data, |
There was a problem hiding this comment.
The API looks very clear.
Why are you dropping headers twice?
There was a problem hiding this comment.
request headers, response headers
| # if pagure_token is not set and we're recording, we'll get a token failure, | ||
| # but that's expected so no need to take care of it | ||
| with use_cassette( | ||
| path=str(Path(__file__).parent / "test_basic_distgit_workflow"), |
There was a problem hiding this comment.
We still need to use the logic from requre to have one file per test. Or some unittest super class to handle that.
There was a problem hiding this comment.
OK, there is some support for this:
Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
|
Build failed.
|
|
I am closing this in the meantime before we come to our decision wrt testing. |
packit/research#41