Comment out worker probes #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we can't install celery from RPM - https://github.com/packit/packit-service/blob/master/files/install-deps-worker.yaml#L22 - we can't install pycurl from RPM -packit/packit-service#823 - base image has to stay with Fedora-31 - packit/packit-service#822 (comment) - the probes don't work with SQS - #135 - the readiness probe sometimes takes a looong time - #135 (comment) - Are they a reliable indicator of the workers health? Don't they actually tell us more about the broker's health?
jpopelka
added a commit
to jpopelka/packit-service
that referenced
this pull request
Sep 21, 2020
Depends-on: packit/deployment#142
|
Build succeeded.
|
csomh
approved these changes
Sep 21, 2020
lachmanfrantisek
approved these changes
Sep 21, 2020
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know it's a good practice to have the probes, but I have enough of trying to
pip install pycurl, because we can't install it and celery with dnf - because of the probes.