Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Liveness probe #76

Merged
merged 3 commits into from Feb 2, 2023
Merged

Liveness probe #76

merged 3 commits into from Feb 2, 2023

Conversation

jpopelka
Copy link
Member

@jpopelka jpopelka commented Feb 1, 2023 •
edited

LIVENESS_FILE is touched upon each received message.
The liveness probe checks how much time has passed since it and if it's more than LIVENESS_TIMEOUT (5min), returns 1.

@softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@jpopelka jpopelka marked this pull request as ready for review February 2, 2023 07:38
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ pre-commit SUCCESS in 1m 36s

lachmanfrantisek
lachmanfrantisek approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@lachmanfrantisek lachmanfrantisek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@csomh
Copy link
Contributor

csomh commented Feb 2, 2023

Could the modification time of the file be used instead of writing the timestamp in the file? I.e.: Path.touch() and Path.stat().st_mtime.

lbarcziova
lbarcziova approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

TomasTomecek
TomasTomecek approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is really nice: modern smart pidfiles

I hope that openshift will let us know once exit(1) happens

@jpopelka
Copy link
Member Author

jpopelka commented Feb 2, 2023

Could the modification time of the file be used instead of writing the timestamp in the file?

Good point! PTAL @csomh

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ pre-commit SUCCESS in 1m 36s

csomh
csomh approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@csomh csomh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💲 bash 💻

files/liveness.sh Show resolved Hide resolved
@TomasTomecek TomasTomecek mentioned this pull request Feb 2, 2023
Open
@jpopelka
Liveness probe
e2c7900 
LIVENESS_FILE is touched upon each received message.
The liveness probe checks how much time has passed since it
and if it's more than LIVENESS_TIMEOUT (5min), returns 1.
@jpopelka jpopelka added the mergeit When set, zuul wil gate and merge the PR. label Feb 2, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ pre-commit SUCCESS in 1m 51s

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ pre-commit SUCCESS in 1m 35s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit ce96599 into packit:main Feb 2, 2023
@jpopelka jpopelka deleted the liveness branch February 2, 2023 16:05
@jpopelka jpopelka mentioned this pull request Feb 2, 2023
Merged
softwarefactory-project-zuul bot added a commit to packit/deployment that referenced this pull request Feb 3, 2023
@softwarefactory-project-zuul
Fedmsg liveness probe (#443)
6c940e9 
Fedmsg liveness probe

Related to packit/packit-service-fedmsg#76

Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasTomecek TomasTomecek TomasTomecek approved these changes

@csomh csomh csomh approved these changes

@lachmanfrantisek lachmanfrantisek lachmanfrantisek approved these changes

@lbarcziova lbarcziova lbarcziova approved these changes

Assignees
No one assigned
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jpopelka @csomh @TomasTomecek @lachmanfrantisek @lbarcziova