Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Anitya #91

Merged
merged 8 commits into from
Oct 18, 2023
Merged

Conversation

mfocko
Copy link
Member

@mfocko mfocko commented Oct 17, 2023

Signed-off-by: Matej Focko <mfocko@redhat.com>
Signed-off-by: Matej Focko <mfocko@redhat.com>
Signed-off-by: Matej Focko <mfocko@redhat.com>
Signed-off-by: Matej Focko <mfocko@redhat.com>
Signed-off-by: Matej Focko <mfocko@redhat.com>
@softwarefactory-project-zuul
Copy link
Contributor

Signed-off-by: Matej Focko <mfocko@redhat.com>
@softwarefactory-project-zuul
Copy link
Contributor

Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely factored out! 🚀

packit_service_fedmsg/callbacks.py Outdated Show resolved Hide resolved
packit_service_fedmsg/callbacks.py Outdated Show resolved Hide resolved
pass_to_service=False,
)

new_versions = nested_get(event, "message", "project", "upstream_versions")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how will this work if there are multiple new versions? Could you point me to the docs explaining these, e.g. "upstream_versions" vs "version" (and maybe add a comment with this link please)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good question, open for discussion IMO 😂 docs

I think this applies mainly to the upstreams that keep multiple running branches (like kernel, maybe Java (? even though they have separate RPM packages for that)).

OTOH this is something that I can see used with CentOS specifically, because if there are multiple major/minor releases maintained, user should be able to specify some tag filtering in sense of “I want to follow this branch instead of the latest one”.

Given this example, these are the relevant fields:

  • upstream_versions: which are apparently the newly detected versions
  • stable_versions: duh…
  • versions: all versions (including stable, newly detected and prereleases; literally all)
  • old_version (not relevant, but worth mentioning): latest from version, CAN be prerelease

I think we'll need to adjust this in the Service…

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, got it, thanks for the explanation!

I think we'll need to adjust this in the Service

👍

mfocko and others added 2 commits October 17, 2023 15:55
When logging the unconfigured CentOS version update, correctly get the package name.

Co-authored-by: Laura Barcziová <49026743+lbarcziova@users.noreply.github.com>
Co-authored-by: Laura Barcziová <49026743+lbarcziova@users.noreply.github.com>
@softwarefactory-project-zuul
Copy link
Contributor

@mfocko mfocko added the mergeit When set, zuul wil gate and merge the PR. label Oct 18, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/b6be1f29f1d342a9a525b25de04d26d8

✔️ pre-commit SUCCESS in 1m 16s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 4e9af0f into packit:main Oct 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants