Status for propose-downstream job
#1293
Labels
area/fedora
Related to Fedora ecosystem
area/user-experience
Usability issue
kind/feature
New feature or a request for enhancement.
Comments
lachmanfrantisek
added
kind/feature
4 tasks
softwarefactory-project-zuul bot
added a commit
that referenced
this issue
Apr 12, 2022
Propose downstream reporting Fixes #1293 As for the helper classes, I extracted the common logic to the BaseJobHelper and then added propose-downstream specific logic into ProposeDownstreamJobHelper. Since we already have also TestingFarmJobHelper which was placed directly in the worker directory, I created a dedicated helpers directory and moved these + the build dir including build helpers there. It is still not ideal (especially the testing farm inheriting from BaseBuildJobHelper but being placed outside of build dir), but current class hierarchy is: BaseJobHelper BaseBuildJobHelper CoprBuildJobHelper KojiBuildJobHelper TestingFarmJobHelper ProposeDownstreamHelper We can still discuss some better structure. RELEASE NOTES BEGIN TBD RELEASE NOTES END Reviewed-by: Tomas Tomecek <tomas@tomecek.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Use check-runs/commit-status to show users the state of the
propose-downstreamjob in the place it was triggered (release commit or a new commit for the branch push once #1284 is done).For
propose-downstreamtriggered by an issue comment, create a comment as well as the commit status.Relates to #1292 and packit/dashboard#155 (link the dashboard view once it's implemented).
The text was updated successfully, but these errors were encountered: