Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create bodhi update for successful Koji build #74

Closed
msehnout opened this issue Aug 1, 2019 · 6 comments · Fixed by #1332
Closed

create bodhi update for successful Koji build #74

msehnout opened this issue Aug 1, 2019 · 6 comments · Fixed by #1332
Assignees
@lachmanfrantisek
Labels
complexity/epic Lost of work ahead, planning/design required. downstream kind/feature New feature or a request for enhancement.
Projects
Packit Epic board

Comments

@msehnout
Copy link

msehnout commented Aug 1, 2019

The documentation says, that packit can build RPM in koji and propose updates in bodhi. Can packit-as-a-service do this automatically for us?
https://packit.dev/docs/cli/create-bodhi-update/

My idea is like this:

  • I push a new tag
  • New release on github is created
  • koji build is triggered
  • if successful, bodhi update is proposed

WDYT?
@TomasTomecek
Copy link
Member

Yes it could, we just need to implement this in the service :) Moving this over there.

@TomasTomecek TomasTomecek transferred this issue from packit/packit Aug 2, 2019
@rpitonak rpitonak added the kind/feature New feature or a request for enhancement. label Aug 2, 2019
@lachmanfrantisek lachmanfrantisek added the triaged This issue was already processed by the team. label Aug 15, 2019
@stale
Copy link

stale bot commented Nov 5, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Is the issue still valid? label Nov 5, 2019
@msehnout
Copy link
Author

msehnout commented Nov 5, 2019

wontfix? If anything I would prefer postpone :)

@stale stale bot removed the stale Is the issue still valid? label Nov 5, 2019
@dhodovsk dhodovsk added pinned Ignored by stale-bot. complexity/epic Lost of work ahead, planning/design required. labels Nov 6, 2019
@jpopelka
Copy link
Member

jpopelka commented Nov 6, 2019

wontfix?

renamed to stale and added pinned so that stale bot doesn't bother you in future

@dhodovsk
Copy link
Contributor

dhodovsk commented Nov 6, 2019 •
edited

We might plan to implement it in the future, however, it is not a priority for us.

Our focus right now is rawhide and continuous integration, not updating stable releases of Fedora.

Somewhere in the process, there will have to be propose-update to include the changes from github release.

@dhodovsk dhodovsk removed the pinned Ignored by stale-bot. label Nov 12, 2019
@lachmanfrantisek lachmanfrantisek added downstream and removed triaged This issue was already processed by the team. labels Jul 8, 2021
@lachmanfrantisek lachmanfrantisek added this to To do in Packit Epic board via automation Jul 8, 2021
@TomasTomecek TomasTomecek moved this from To do to Packit-as-a-Service GitHub App in Packit Epic board Jul 8, 2021
@lachmanfrantisek lachmanfrantisek mentioned this issue Sep 7, 2021
Closed
7 tasks
@csomh csomh mentioned this issue Oct 6, 2021
Closed
4 tasks
@lachmanfrantisek
Copy link
Member

lachmanfrantisek commented Nov 25, 2021 •
edited

TODO:

  • create a new job type for updates (in Packit repo)
  • create a new handler that will listen to the successful Koji build
    • get the correct state of the dist-git (for the commit that was used for build)
    • trigger the bodhi update using the Packit's Python API

@lachmanfrantisek lachmanfrantisek mentioned this issue Dec 2, 2021
Closed
3 tasks
@lachmanfrantisek lachmanfrantisek changed the title create bodhi update when a new tag is pushed into the repository create bodhi update for successful Koji build Jan 28, 2022
@lachmanfrantisek lachmanfrantisek mentioned this issue Jan 28, 2022
Merged
Packit Epic board automation moved this from Packit-as-a-Service GitHub App to Done Feb 1, 2022
softwarefactory-project-zuul bot added a commit that referenced this issue Feb 1, 2022
@softwarefactory-project-zuul
Merge pull request #1332 from lachmanfrantisek/bodhi-update-for-koji-…
153fc3f 
…build

Bodhi update for koji build

We are reacting on successful production (=non-scratch) Koji builds.
The bodhi update is created only when the job is configured for the fedora version (=branch) the build is for.
I suggest going commit-by-commit when reviewing since there is a class rename making the overall diff a bit messy.

Fixes: #74
Merge after: packit/packit#1466 (required for tests to pass)

There is a new job that you can use to automatically create a Bodhi update once a Koji Build successfully finishes.

Reviewed-by: Jiri Popelka <None>
Reviewed-by: None <None>
Reviewed-by: Tomas Tomecek <tomas@tomecek.net>
Reviewed-by: Laura Barcziová <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachmanfrantisek lachmanfrantisek

Labels
complexity/epic Lost of work ahead, planning/design required. downstream kind/feature New feature or a request for enhancement.
Projects
No open projects
Packit Epic board
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bodhi update for koji build lachmanfrantisek/packit-service
6 participants
@jpopelka @TomasTomecek @msehnout @lachmanfrantisek @rpitonak @dhodovsk