Add /projects/{forge} API endpoint #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpopelka
approved these changes
Jul 15, 2021
|
Build succeeded.
|
| result = [] | ||
| first, last = indices() | ||
|
|
||
| projects_list = GitProjectModel.get_forge(first, last, forge) |
There was a problem hiding this comment.
what's the expectation for the forge argument? https://github.com or github.com?
I'm wondering what would be the most convenient way for API users to use the endpoint
| @@ -599,6 +599,18 @@ def test_get_project(clean_before_and_after, a_copr_build_for_pr): | |||
| assert project.project_url == "https://github.com/the-namespace/the-repo-name" | |||
|
|
|||
|
|
|||
| def test_get_forge(clean_before_and_after, multiple_forge_projects): | |||
| projects = GitProjectModel.get_forge(0, 10, "github.com") | |||
There was a problem hiding this comment.
oki, here's my answer :D
so will https://github.com work as well?
There was a problem hiding this comment.
no, this will not work, as in other similar methods
lbarcziova
force-pushed
the
projects-forge-api
branch
from
6031b43
to
f9d39cc
Compare
TomasTomecek
approved these changes
Jul 15, 2021
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for packit/dashboard#61