Catch the new Copr exception that is newly raised by Copr #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
mfocko
reviewed
Apr 27, 2022
| @@ -452,7 +452,7 @@ def submit_copr_build(self, script: Optional[str] = None) -> Tuple[int, str]: | |||
| }, | |||
| ) | |||
|
|
|||
| except CoprRequestException as ex: | |||
| except (CoprRequestException, CoprAuthException) as ex: | |||
| if "You don't have permissions to build in this copr." in str( | |||
There was a problem hiding this comment.
do we still need to match the text of the exception if it's separate exception now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Frantisek Lachman flachman@redhat.com
Fixes: #1471
RELEASE NOTES BEGIN
The bug in the Copr permission request is now fixed. (After the release of a new Copr client, Packit didn't catch that permission problem and didn't request the permissions to build in a custom Copr project.) You can wait for the fix to be deployed and retrigger the action or let the Packit team know to make the request manually.
RELEASE NOTES END