Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduce copr targets #1673

Merged
merged 2 commits into from Sep 22, 2022

Conversation

mfocko
Copy link
Member

@mfocko mfocko commented Sep 22, 2022

TODO:

  • Write new tests or update the old ones to cover new functionality.
  • Update doc-strings where appropriate.
  • Update or write new documentation in packit/packit.dev.

Fixes #1499


RELEASE NOTES BEGIN
Packit now deduces Copr targets for Copr builds when you have set your custom Copr project to be used.
RELEASE NOTES END

If there are no configured build targets and custom Copr project is
configured, then fetch the targets and use them for the build.

Fixes packit#1499

Signed-off-by: Matej Focko <mfocko@redhat.com>
Reflect deducing of Copr targets from custom Copr project.

Signed-off-by: Matej Focko <mfocko@redhat.com>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ pre-commit SUCCESS in 2m 00s
✔️ packit-service-tests SUCCESS in 2m 04s
✔️ packit-service-tests-openshift SUCCESS in 11m 10s

@mfocko mfocko added the ready-for-review Pull request is ready for review. label Sep 22, 2022
Copy link
Member

@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

@mfocko mfocko added the mergeit When set, zuul wil gate and merge the PR. label Sep 22, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ pre-commit SUCCESS in 2m 06s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 0974490 into packit:main Sep 22, 2022
mfocko added a commit to mfocko/packit.dev that referenced this pull request Oct 4, 2022
Follow-up of packit/packit-service#1673

Signed-off-by: Matej Focko <mfocko@redhat.com>
mfocko added a commit to mfocko/packit.dev that referenced this pull request Oct 5, 2022
Follow-up of packit/packit-service#1673

Signed-off-by: Matej Focko <mfocko@redhat.com>
mfocko added a commit to mfocko/packit.dev that referenced this pull request Oct 5, 2022
Follow-up of packit/packit-service#1673

Signed-off-by: Matej Focko <mfocko@redhat.com>
softwarefactory-project-zuul bot added a commit to packit/packit.dev that referenced this pull request Oct 5, 2022
fix(copr): mention deducing Copr targets

Follow-up of packit/packit-service#1673
Signed-off-by: Matej Focko mfocko@redhat.com

Reviewed-by: Laura Barcziová <None>
Reviewed-by: None <None>
Reviewed-by: Matej Focko <None>
@mfocko mfocko deleted the deduce-copr-targets branch July 11, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR. ready-for-review Pull request is ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discover targets when building in users Copr repo
2 participants