New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduce copr targets #1673
Merged
softwarefactory-project-zuul
merged 2 commits into
packit:main
from
mfocko:deduce-copr-targets
Sep 22, 2022
Merged
Deduce copr targets #1673
softwarefactory-project-zuul
merged 2 commits into
packit:main
from
mfocko:deduce-copr-targets
Sep 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are no configured build targets and custom Copr project is configured, then fetch the targets and use them for the build. Fixes packit#1499 Signed-off-by: Matej Focko <mfocko@redhat.com>
Reflect deducing of Copr targets from custom Copr project. Signed-off-by: Matej Focko <mfocko@redhat.com>
Build succeeded. ✔️ pre-commit SUCCESS in 2m 00s |
TomasTomecek
approved these changes
Sep 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏻
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 2m 06s |
mfocko
added a commit
to mfocko/packit.dev
that referenced
this pull request
Oct 4, 2022
Follow-up of packit/packit-service#1673 Signed-off-by: Matej Focko <mfocko@redhat.com>
mfocko
added a commit
to mfocko/packit.dev
that referenced
this pull request
Oct 5, 2022
Follow-up of packit/packit-service#1673 Signed-off-by: Matej Focko <mfocko@redhat.com>
mfocko
added a commit
to mfocko/packit.dev
that referenced
this pull request
Oct 5, 2022
Follow-up of packit/packit-service#1673 Signed-off-by: Matej Focko <mfocko@redhat.com>
softwarefactory-project-zuul bot
added a commit
to packit/packit.dev
that referenced
this pull request
Oct 5, 2022
fix(copr): mention deducing Copr targets Follow-up of packit/packit-service#1673 Signed-off-by: Matej Focko mfocko@redhat.com Reviewed-by: Laura Barcziová <None> Reviewed-by: None <None> Reviewed-by: Matej Focko <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
mergeit
When set, zuul wil gate and merge the PR.
ready-for-review
Pull request is ready for review.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
packit/packit.dev
.Fixes #1499
RELEASE NOTES BEGIN
Packit now deduces Copr targets for Copr builds when you have set your custom Copr project to be used.
RELEASE NOTES END