Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide more generic statuses in Gitlab on build submission #1975

Merged
merged 1 commit into from Mar 29, 2023
Merged

Provide more generic statuses in Gitlab on build submission #1975

merged 1 commit into from Mar 29, 2023

Conversation

lbarcziova
Copy link
Member

Since in GitLab, we are not able to overwrite the pending statuses with new descriptions and links, provide more generic ones (for builds, provide the Copr web URL, for tests, the dashboard testing farm jobs view).

Fixes #1914

TODO:

  • Write new tests or update the old ones to cover new functionality.
  • Update doc-strings where appropriate.

RELEASE NOTES BEGIN
Since in GitLab, it is not possible to overwrite the pending statuses, Packit now provides more generic descriptions and URLs when setting the first pending status.
RELEASE NOTES END

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/c43a9466d8004f318d583bf70aae5faf

✔️ pre-commit SUCCESS in 2m 23s
✔️ packit-service-tests SUCCESS in 2m 18s
✔️ packit-service-tests-openshift SUCCESS in 12m 04s

jpopelka
jpopelka approved these changes Mar 28, 2023
View reviewed changes
packit_service/constants.py Outdated Show resolved Hide resolved
@lbarcziova
Provide more generic statuses in Gitlab on build submission
d32638b 
Since in GitLab we are not able to overwrite the pending statuses with
new descriptions and links, provide more generic ones
(for builds provide the Copr web URL, for tests the dashboard testing farm jobs view).

Fixes packit#1914
@lbarcziova lbarcziova force-pushed the gitlab-generic-pending-statuses branch from 2adcd3d to d32638b Compare March 28, 2023 17:04
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/f04ebf2c84ff4a63af1f278ed17bbc4c

✔️ pre-commit SUCCESS in 2m 08s
✔️ packit-service-tests SUCCESS in 2m 07s
✔️ packit-service-tests-openshift SUCCESS in 12m 53s

@lbarcziova lbarcziova added the mergeit When set, zuul wil gate and merge the PR. label Mar 29, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline).

https://softwarefactory-project.io/zuul/t/packit-service/buildset/eddce94bb82f45189d723cf92487d8ce

❌ pre-commit POST_FAILURE in 2m 01s

@lbarcziova
Copy link
Member Author

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/e19b87ef34ab4154a6df699a105464dd

✔️ pre-commit SUCCESS in 2m 09s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 2083a13 into packit:main Mar 29, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpopelka jpopelka jpopelka approved these changes

Assignees
No one assigned
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More generic descriptions for pending statuses in GitLab
2 participants
@lbarcziova @jpopelka