Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/packit service/1328 bis #2070

Merged
merged 9 commits into from
Aug 8, 2023
Merged

Fix/packit service/1328 bis #2070

merged 9 commits into from
Aug 8, 2023

Conversation

majamassarini
Copy link
Member

@majamassarini majamassarini commented May 29, 2023 •
edited

Fixes #1328 (point 3)

The new db diagram:
ERDiagram

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/a02f9e05c4fe42c494581d89fac67637

✔️ pre-commit SUCCESS in 2m 10s
❌ packit-service-tests FAILURE in 4m 03s
❌ packit-service-tests-openshift FAILURE in 16m 03s

@majamassarini majamassarini mentioned this pull request Jun 5, 2023
Closed
7 tasks
@majamassarini majamassarini force-pushed the fix/packit-service/1328-bis branch 2 times, most recently from a9c2db9 to 0c670bc Compare June 28, 2023 10:53
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/268eec83c0ca4c98a31d6639e8cbfadb

✔️ pre-commit SUCCESS in 2m 06s
✔️ packit-service-tests SUCCESS in 2m 24s
✔️ packit-service-tests-openshift SUCCESS in 15m 21s

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/49bfdef041f44e3ca8938caa9979e265

✔️ pre-commit SUCCESS in 2m 10s
✔️ packit-service-tests SUCCESS in 2m 25s
✔️ packit-service-tests-openshift SUCCESS in 13m 33s

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/5bf8c38e4e7141139cc4358c6db8c6df

✔️ pre-commit SUCCESS in 2m 06s
❌ packit-service-tests FAILURE in 5m 13s
✔️ packit-service-tests-openshift SUCCESS in 12m 44s

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/5f00c941f83243d0bdca5be531a486d6

✔️ pre-commit SUCCESS in 2m 13s
❌ packit-service-tests FAILURE in 6m 19s
✔️ packit-service-tests-openshift SUCCESS in 13m 22s

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/6e658051429648989ff6c939bae9e3bd

✔️ pre-commit SUCCESS in 1m 55s
❌ packit-service-tests FAILURE in 6m 45s
✔️ packit-service-tests-openshift SUCCESS in 13m 46s

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/b95e6ef25711456aa732aa36269f6e86

✔️ pre-commit SUCCESS in 1m 54s
✔️ packit-service-tests SUCCESS in 2m 16s
❌ packit-service-tests-openshift FAILURE in 17m 41s

@majamassarini
Copy link
Member Author

recheck

@softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/41dbb15ad4a445e9a42a40f67550b2e6

❌ pre-commit FAILURE in 1m 37s
✔️ packit-service-tests SUCCESS in 1m 49s
✔️ packit-service-tests-openshift SUCCESS in 15m 20s

@softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/f76fe3e3b265407db0a9328d7d060691

❌ pre-commit FAILURE in 1m 43s
✔️ packit-service-tests SUCCESS in 1m 55s
❌ packit-service-tests-openshift RETRY_LIMIT in 40s

@majamassarini
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/e5225a1338264c088f6c24c77c857b38

✔️ pre-commit SUCCESS in 1m 54s
✔️ packit-service-tests SUCCESS in 2m 08s
❌ packit-service-tests-openshift RETRY_LIMIT in 34s

@majamassarini
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/e860d59246ba486f8ef44440687c5992

✔️ pre-commit SUCCESS in 1m 43s
✔️ packit-service-tests SUCCESS in 2m 23s
❌ packit-service-tests-openshift RETRY_LIMIT in 41s

@majamassarini
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/8c87dcdf3bb64093905321d9937f9e2c

✔️ pre-commit SUCCESS in 1m 50s
✔️ packit-service-tests SUCCESS in 2m 03s
✔️ packit-service-tests-openshift SUCCESS in 11m 32s

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/c95b5da0c1d54be58c1debf5e7b104f9

✔️ pre-commit SUCCESS in 1m 46s
✔️ packit-service-tests SUCCESS in 2m 03s
❌ packit-service-tests-openshift FAILURE in 17m 31s

@majamassarini majamassarini mentioned this pull request Aug 7, 2023
Merged
@majamassarini
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/48475eccea0344cb9c4b05d3f4539d19

❌ pre-commit FAILURE in 1m 57s
✔️ packit-service-tests SUCCESS in 2m 03s
✔️ packit-service-tests-openshift SUCCESS in 12m 43s

@majamassarini
Move commit_sha to ProjectEventModel table
91f4dae
@majamassarini
Use ProjectEventModel to get an AbstractProjectObjectDbType
3d08f40 
Many ProjectEventModel(s) can work on the same
AbstractProjectObjectDbType (as an example
many pull request pushes can work on the same pull request object).
We need to pass around the event, because we can not
get an event from the object (we will end up with multiple events...).
@majamassarini
Remove db_project_object from methods signatures
0bf0dba 
The db_project_object is retrieved through the related db_project_event.
@majamassarini
commit_sha data migration
384e75f
@majamassarini
Add new ER diagram
33e2e0e
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/15325c062fbd412d9fe7f3d90f768e49

✔️ pre-commit SUCCESS in 1m 43s
✔️ packit-service-tests SUCCESS in 2m 10s
✔️ packit-service-tests-openshift SUCCESS in 13m 18s

@majamassarini majamassarini mentioned this pull request Aug 7, 2023
Closed
lbarcziova
lbarcziova reviewed Aug 8, 2023
View reviewed changes
Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is admirable work Maja!! 🚀

just a few notes, it would be nice to get this to staging and test it there

as for the migration, have you tested that with the production data?

packit_service/models.py Outdated Show resolved Hide resolved
alembic/versions/af00a7f19025_move_commit_sha_to_project_events.py Show resolved Hide resolved
alembic/versions/af00a7f19025_move_commit_sha_to_project_events.py Outdated Show resolved Hide resolved
packit_service/models.py Outdated Show resolved Hide resolved
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/4ce0f191baf34c319b94bf424154a7cd

✔️ pre-commit SUCCESS in 2m 35s
✔️ packit-service-tests SUCCESS in 4m 55s
❌ packit-service-tests-openshift FAILURE in 17m 05s

@majamassarini
Copy link
Member Author

as for the migration, have you tested that with the production data?

Yes, on my laptop with the production data the migration took more than half an hour but less than an hour.

majamassarini and others added 4 commits August 8, 2023 09:55
@majamassarini
Do not serialize the db_project_object
d2f9eaa
@majamassarini @lbarcziova
Improve documentation
affd5be 
Co-authored-by: Laura Barcziová <49026743+lbarcziova@users.noreply.github.com>
@majamassarini @lbarcziova
Use String instead of VARCHAR in migration
5aba8a6 
Co-authored-by: Laura Barcziová <49026743+lbarcziova@users.noreply.github.com>
@majamassarini
Test project event model when accessing commit_sha
c5cec06
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/c1c0069b8a1d46f6b2a14f2cb98e5a05

✔️ pre-commit SUCCESS in 2m 11s
✔️ packit-service-tests SUCCESS in 2m 37s
❌ packit-service-tests-openshift RETRY_LIMIT in 2m 04s

@majamassarini
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/fc35be2d09994b19baf05b2c62b71160

✔️ pre-commit SUCCESS in 2m 07s
✔️ packit-service-tests SUCCESS in 2m 42s
✔️ packit-service-tests-openshift SUCCESS in 15m 14s

lbarcziova
lbarcziova approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's ship it!

thanks Maja for taking this complext issue!

@majamassarini majamassarini added the mergeit When set, zuul wil gate and merge the PR. label Aug 8, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/1e4495e3ebc2475091cda80f31530b11

✔️ pre-commit SUCCESS in 1m 55s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 314a380 into packit:main Aug 8, 2023
3 checks passed
softwarefactory-project-zuul bot added a commit to packit/hardly that referenced this pull request Aug 10, 2023
@softwarefactory-project-zuul
commit_sha has been moved to project_events table (#108)
a436767 
commit_sha has been moved to project_events table

Merge after packit/packit-service#2070

Reviewed-by: Laura Barcziová
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbarcziova lbarcziova lbarcziova approved these changes

Assignees
No one assigned
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Database: project reference model
2 participants
@majamassarini @lbarcziova