Fix multiple run models exception for API #2165
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
|
recheck |
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 43s |
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 47s |
The exception should not be raised, as we are getting project event from the project objects such as PR/branch push/release/issues and for these, there can be multiple project events (e.g. PR with multiple pushes). Fixes packit#2153
lbarcziova
force-pushed
the
multiple-project-events-bug
branch
from
f08f9e9
to
c73b54b
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 43s |
| @property | ||
| def commit_sha(self) -> str: | ||
| project_event = self.get_project_event() | ||
| return project_event.commit_sha if project_event else None | ||
|
|
There was a problem hiding this comment.
I thought we need this one, but looking at the tests it seems we don't.
Thanks for the fix!
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 45s |
softwarefactory-project-zuul
bot
merged commit badd457
into
packit:main
The exception should not be raised, as we are getting project event from the project objects such as PR/branch push/release/issues and for these, there can be multiple project events (e.g. PR with multiple pushes). Fixes #2153
TODO:
RELEASE NOTES BEGIN
We have fixed a bug causing issues with displaying some Project views in our dashboard.
RELEASE NOTES END