Move local-project dir inside sandcastle subfolder #2166
Conversation
|
Build failed. ✔️ pre-commit SUCCESS in 3m 00s |
majamassarini
force-pushed
the
fix/packit-service/1956
branch
2 times, most recently
from
2200b49
to
cca9cb9
Compare
|
Build failed. ✔️ pre-commit SUCCESS in 6m 38s |
majamassarini
force-pushed
the
fix/packit-service/1956
branch
from
cca9cb9
to
79121b2
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 54s |
packit_service/constants.py
Outdated
| SANDCASTLE_DG_REPO_DIR = "dg" | ||
| SANDCASTLE_LOCAL_PROJECT_DIR = "local-project" |
There was a problem hiding this comment.
I know the names don't matter much, but if local project working dir is in fact the upstream repo, why not use upstream and downstream/dist-git?
There was a problem hiding this comment.
The LocalProjectMixin sets the suffix for this dir. The local project can be both an upstream or downstream project, it depends on the others mixins in the handler...
I can be sure only about the dg suffix, because it is used by the PackitAPIWithUpstreamMixin which is setting it.
The PackitAPIWithUpstreamMixin "depends" on the LocalProjectMixin so it is too late to specify the suffix for the upstream in PackitAPIWithUpstreamMixin.
And I have no other ideas...
I choose dg as a name because in the API is called like that, but I can change it in dist-git if you think it is better.
There was a problem hiding this comment.
Yes, I think dist-git is better, dg makes sense in the code as it is shorter, but I think we can afford to be a bit more explicit in directory names 🙂
|
I'd change release notes to something like this: Packit now sets |
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 44s |
Me neither, because I can not test locally actions in sandcastle, since I have not openshift. |
It would be good if someone else had a look before merging, but I don't think this can break anything, so let's test it on stage. |
We need both upstream and dowstream repos in sandcastle shared folder for a sync_release. Co-authored-by: Nikola Forró <nforro@redhat.com>
majamassarini
force-pushed
the
fix/packit-service/1956
branch
from
bdf9774
to
bcc1314
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 39s |
Make dg repo accessible by an action Fixes packit/packit-service#1956 Merge before packit/packit-service#2166 Reviewed-by: Nikola Forró Reviewed-by: Maja Massarini Reviewed-by: Laura Barcziová
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 42s |
softwarefactory-project-zuul
bot
merged commit b7d6775
into
packit:main
We need both upstream and dowstream repos in sandcastle shared folder.
For this reason I need to move the upstream repo from the root to a subfolder.
Fixes #1956
Merge after packit/packit#2054
RELEASE NOTES BEGIN
Packit now sets
PACKIT_UPSTREAM_REPOandPACKIT_DOWNSTREAM_REPOenvironment variables for release syncing actions. The variables represent paths where the respective git repositories are clonedRELEASE NOTES END