Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide manual test statuses only when build handler is required #2389

Merged
merged 1 commit into from Apr 4, 2024
Merged

Hide manual test statuses only when build handler is required #2389

merged 1 commit into from Apr 4, 2024

Conversation

lbarcziova
Copy link
Member

@lbarcziova lbarcziova commented Apr 4, 2024 •
edited

We should not check the labels and identifiers, this should be handled by pre-checks and results in no reporting for TF notifications.

Fixes #2386

TODO:

  • testcase

RELEASE NOTES BEGIN

We have fixed reporting of tests with manual_trigger: True.

RELEASE NOTES END

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/ed3ee391e1f941c0aec3129f2d556e72

✔️ pre-commit SUCCESS in 2m 16s
✔️ packit-service-tests SUCCESS in 2m 23s

majamassarini
majamassarini approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@majamassarini majamassarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the feeling that something is missing but this can be tested on stg.
Just one note about the testing, I found out that many corner cases where related with no having a build yet.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/45a91df4b1ee4bfe85930f1d971518f9

✔️ pre-commit SUCCESS in 2m 19s
✔️ packit-service-tests SUCCESS in 2m 11s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/da52a881ac344cd58b6b19778136ea92

✔️ pre-commit SUCCESS in 2m 32s
✔️ packit-service-tests SUCCESS in 2m 07s

@lbarcziova
Hide manual test statuses only when build handler is required
a37db92 
We should not check the labels and identifiers, this should be
handled by pre-checks and results in no reporting for TF notifications.

Fixes packit#2386
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/4d78953d04884b6dab3ad7ff66d8b37c

✔️ pre-commit SUCCESS in 2m 24s
✔️ packit-service-tests SUCCESS in 2m 09s

@lbarcziova lbarcziova added the mergeit When set, zuul wil gate and merge the PR. label Apr 4, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/afb20316cb0c4d118819658871d64062

✔️ pre-commit SUCCESS in 2m 19s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit cef6943 into packit:main Apr 4, 2024
4 of 5 checks passed
@lbarcziova lbarcziova deleted the hiding-fix branch April 4, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majamassarini majamassarini majamassarini approved these changes

Assignees
No one assigned
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing reporting for manual tests
2 participants
@lbarcziova @majamassarini