Be more explicit about who can trigger PaaS #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"collaborators" was not an exact definition for who can trigger Packit-as-a-Service. Make sure the error message is explicit about the GitHub permissions required. Partially fixes #442. Signed-off-by: Hunor Csomortáni <csomh@redhat.com>
| @@ -380,7 +383,10 @@ def __init__(self, config: ServiceConfig, event: PullRequestCommentEvent): | |||
| def run(self) -> HandlerResults: | |||
| collaborators = self.project.who_can_merge_pr() | |||
| if self.event.github_login not in collaborators | self.config.admins: | |||
| msg = "Only collaborators can trigger Packit-as-a-Service" | |||
| msg = ( | |||
| "Only users with write or admin permissions to the repository " | |||
There was a problem hiding this comment.
I am only a little confused about the write permissions meaning. (Since in the comments, you can see terms like member, collaborator, ...)
There was a problem hiding this comment.
If I understand it correctly than member and collaborator are org membership terms (roles?), but we check for repository permission levels.
(Yes, this part of GitHub is very confusing.)
|
Build succeeded.
|
lachmanfrantisek
approved these changes
Mar 2, 2020
TomasTomecek
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"collaborators" was not an exact definition for who can trigger
Packit-as-a-Service. Make sure the error message is explicit about the
GitHub permissions required.
Partially fixes #442.
Signed-off-by: Hunor Csomortáni csomh@redhat.com