Use integer response code values #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
TomasTomecek
reviewed
Aug 5, 2020
IceWreck
force-pushed
the
correct--api-codes
branch
from
85f018a
to
1d6110e
Compare
|
Build succeeded.
|
|
Done |
IceWreck
force-pushed
the
correct--api-codes
branch
from
1d6110e
to
a4b6def
Compare
|
Build failed.
|
IceWreck
force-pushed
the
correct--api-codes
branch
from
a4b6def
to
b17064c
Compare
|
what happened to zuul? /recheck |
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @Stranger6667 for reporting it in #368 (comment)
Basically we were sending and documenting the response status object instead of the integer code as required by RestX and the return value to a view should also have an integer code as status.
https://docs.python.org/3/library/http.html