Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the update retrigger instructions clear #892

Merged
merged 1 commit into from Nov 30, 2020
Merged

Make the update retrigger instructions clear #892

merged 1 commit into from Nov 30, 2020

Conversation

lbarcziova
Copy link
Member

To have it consistent with the one for build:

packit-service/packit_service/constants.py

Lines 21 to 24 in 45903cf

MSG_RETRIGGER = (
"You can re-trigger build by adding a comment (`/packit {build}`) "
"into this pull request."
)

Fixes #829

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

mfocko
mfocko reviewed Nov 26, 2020
View reviewed changes
Copy link
Member

@mfocko mfocko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you have the snippet in the PR description, could it be used as format string? Appears to differ only in the command to be used and build vs update.

Otherwise LGTM :)

packit_service/worker/handlers/github_handlers.py Outdated Show resolved Hide resolved
TomasTomecek
TomasTomecek reviewed Nov 27, 2020
View reviewed changes
Copy link
Member

@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice wording; @mfocko +1, retrigger is the correct word (even though e.g. firefox's spellcheck doesn't like it)

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

lachmanfrantisek
lachmanfrantisek approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@lachmanfrantisek lachmanfrantisek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice improvement!

👍 from me

mfocko
mfocko approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@mfocko mfocko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lbarcziova lbarcziova changed the title Make the update re-trigger instructions clear Make the update retrigger instructions clear Nov 30, 2020
@lbarcziova lbarcziova added the mergeit When set, zuul wil gate and merge the PR. label Nov 30, 2020
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 4aab87e into packit:master Nov 30, 2020
@lbarcziova lbarcziova deleted the update-retrigger-instructions branch September 11, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasTomecek TomasTomecek TomasTomecek left review comments

@mfocko mfocko mfocko approved these changes

@lachmanfrantisek lachmanfrantisek lachmanfrantisek approved these changes

Assignees
No one assigned
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UX: make the retrigger instructions clear
4 participants
@lbarcziova @TomasTomecek @mfocko @lachmanfrantisek