Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Configuration] Change default jobs #107

Merged
merged 1 commit into from Mar 5, 2020
Merged

[Configuration] Change default jobs #107

merged 1 commit into from Mar 5, 2020

Conversation

lbarcziova
Copy link
Member

Update in default values in job config (packit/packit#703).

lachmanfrantisek
lachmanfrantisek reviewed Feb 27, 2020
View reviewed changes
Copy link
Member

@lachmanfrantisek lachmanfrantisek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the regeneration did not go well...

content/docs/configuration.md
@@ -183,7 +183,7 @@ jobs:
If there is no `jobs` section in the configuration file, jobs default to:
```
jobs:
- job: copr_build
- job: tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I forgot to do it...

@lbarcziova
Copy link
Member Author

Looks like the regeneration did not go well...

I do not know what's the problem, I did it as always..

@TomasTomecek
Copy link
Member

I am using older hugo, so I regen'd and rebased your PR.

TomasTomecek
TomasTomecek approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and I approve the changes :P

@lbarcziova
Copy link
Member Author

Thanks

@TomasTomecek TomasTomecek merged commit 438c166 into packit:master Mar 5, 2020
@lbarcziova lbarcziova deleted the test_default_job branch September 11, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lachmanfrantisek lachmanfrantisek lachmanfrantisek left review comments

@TomasTomecek TomasTomecek TomasTomecek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lbarcziova @TomasTomecek @lachmanfrantisek