Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Archive name instead of package name in %prep section #868

Closed
lachmanfrantisek opened this issue Jun 17, 2020 · 4 comments · Fixed by #952 or #959
Closed

Archive name instead of package name in %prep section #868

lachmanfrantisek opened this issue Jun 17, 2020 · 4 comments · Fixed by #952 or #959
Assignees
@sakalosj
Labels
kind/bug Something isn't working.

Comments

@lachmanfrantisek
Copy link
Member

lachmanfrantisek commented Jun 17, 2020 •
edited

As we can see here:

There should be an archive name, not the f" -n {self.package_config.upstream_package_name}-{version}" in the %prep section. Or am I wrong?

Relevant code:

packit/packit/upstream.py

Line 480 in 1bb4001

new_setup_line += f" -n {self.package_config.upstream_package_name}-{version}"

@lachmanfrantisek lachmanfrantisek added the kind/bug Something isn't working. label Jun 17, 2020
@jkonecny12
Copy link
Contributor

Hi, any update on this issue?

@TomasTomecek
Copy link
Member

@jkonecny12 sadly not, we are overwhelmed with work to be honest (nothing new) and Summer & PTOs don't make it any better

I can add it to the next sprint if we have enough capacity to work on it.

@jkonecny12
Copy link
Contributor

OK, thanks for info!

@sakalosj sakalosj mentioned this issue Aug 31, 2020
Merged
5 tasks
@lachmanfrantisek lachmanfrantisek linked a pull request Sep 15, 2020 that will close this issue
Use archive in Upstream._fix_spec_prep #952
Merged
5 tasks
@sakalosj sakalosj linked a pull request Sep 22, 2020 that will close this issue
Use upstream_tag_template to get version from tag #959
Merged
2 tasks
@sakalosj
Copy link
Contributor

fixed by #959
rework of setting correct directory in an archive (%setup -n ...) handled in #952

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sakalosj sakalosj

Labels
kind/bug Something isn't working.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use archive in Upstream._fix_spec_prep
Use upstream_tag_template to get version from tag
4 participants
@jkonecny12 @TomasTomecek @sakalosj @lachmanfrantisek