fix tempfile handling #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requre/helpers/tempfile.py
Outdated
|
|
||
|
|
||
| class TempFile(ObjectStorage): | ||
| class mktemp(Simple): |
There was a problem hiding this comment.
Is this name needed? Can we use Python's UperCamelCase class naming style?
|
Build failed.
|
jscotka
force-pushed
the
tempfile
branch
2 times, most recently
from
b0c9690
to
1a7379d
Compare
|
Build failed.
|
jscotka
force-pushed
the
tempfile
branch
2 times, most recently
from
642b7ce
to
c2ed8bb
Compare
|
Build failed.
|
|
Build succeeded.
|
jscotka
added
high-prio
lachmanfrantisek
approved these changes
May 7, 2021
Comment on lines
-31
to
-36
| def cassette_teardown(self, cassette: Cassette): | ||
| self.assertIn( | ||
| "tests.test_modules_decorate_all_methods.ApplyCommonCase.test_git.yaml", | ||
| str(cassette.storage_file), | ||
| ) | ||
|
|
There was a problem hiding this comment.
Why you are removing it?
Isn't there a problem with the new name?
def cassette_teardown(self, cassette: Cassette):
self.assertIn(
"ApplyCommonCase.test_git.yaml",
str(cassette.storage_file),
)There was a problem hiding this comment.
Ah yes, I've removed it, because it failed :-) but I can let check there for sure
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.