Define implementation of adoption metrics #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+147
to
+149
| Overall the simplest solution is the Grafana option. It will be quite challenging if we want to | ||
| make our dashboard publicly visible but it's still easier than gathering the data and displaying | ||
| them by ourselves (dashboard option). |
|
|
||
| Cons: | ||
|
|
||
| - visibility: only internal folks will be able to see the graphs (since our current dashboard |
There was a problem hiding this comment.
I understand this epic to serve mostly our team and colleagues in Red Hat. Am I missing something or is there a requirement that the charts should be publicly accessible?
There was a problem hiding this comment.
- If we can do it publicly, why not do that publically.
- Public service can be easier to access also for internal people.
- Packit marketing.
There was a problem hiding this comment.
Yes, the point is that it would be great to have this data publicly available (for the reasons Franta mentioned above), but it's not necessary (from the key functionality point of view). So there is an option to implement key functionality and later make this data publicly available (using the steps outlined in the PR)
There was a problem hiding this comment.
Exactly. Let's start with the private Grafana and make a public view as a second step.
nikromen
force-pushed
the
implementation-adoption-metrics
branch
from
bf11670
to
952d5a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.