Fix parsing of %prep macros
#356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parsing of %prep macros was incorrect. For instance %patches macro when used in %prep section was wrongly parsed as %patch macro. This commit fixes that. Signed-off-by: Nikola Forró <nforro@redhat.com>
majamassarini
approved these changes
Mar 19, 2024
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 29s |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 2m 32s |
softwarefactory-project-zuul
bot
merged commit e9a63b6
into
main
21 of 32 checks passed
nforro
added a commit
to nforro/authselect
that referenced
this pull request
Mar 20, 2024
It contains a specfile fix [1] that prevents breaking `%prep` in authselect.spec and is not yet in production. [1] packit/specfile#356 Signed-off-by: Nikola Forró <nforro@redhat.com>
nforro
added a commit
to nforro/authselect
that referenced
this pull request
Mar 20, 2024
It contains a specfile fix [1] that prevents breaking `%prep` in authselect.spec and is not yet in production. [1] packit/specfile#356 Signed-off-by: Nikola Forró <nforro@redhat.com>
nforro
added a commit
to nforro/authselect
that referenced
this pull request
Mar 20, 2024
It contains a specfile fix [1] that prevents breaking `%prep` in authselect.spec and is not yet in production. [1] packit/specfile#356 Signed-off-by: Nikola Forró <nforro@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing of
%prepmacros was incorrect. For instance%patchesmacro when used in%prepsection was wrongly parsed as%patchmacro. This commit fixes that.RELEASE NOTES BEGIN
We have fixed an issue in
%prepsection processing. For instance, if the%patchesmacro appeared there, it would have been converted to%patch es, causing failure when executing%preplater.RELEASE NOTES END