Fix GH-82: broken build with special characters in 'Name:' tag

[akopytov]

When generating RPMNAME from the 'Name:' tag in RPM Spec, expand RPM
macros to avoid breaking the build with 1) non-alphanumeric characters
in a Make variable and 2) inconsistencies between package names
generated by RPM tools and the ones being used by packpack.

[akopytov]

CentOS 6 was a problem, because rpmspec is not available there. Fixed.

[rtsisyk]

Sorry for the delay. Pushed, thanks!

[sergeyklay]

@rtsisyk This PR broke our builds for CentOS 7. Now we have such build errors:

sudo dnf builddep -y /build/-3.3.2-1.ius.el7.centos.src.rpm || sudo yum-builddep -y /build/-3.3.2-1.ius.el7.centos.src.rpm

...
...
...

Error: Could not open /build/-3.3.2-1.ius.el7.centos.src.rpm .
Try running yum-builddep with the --nogpgcheck option.
There was a problem getting the build deps, exiting:
   Could not open local rpm file: /build/-3.3.2-1.ius.el7.centos.src.rpm: Unable to open file
make: *** [package] Error 1
rm /build/ls-lR.txt /build/VERSION
make: Leaving directory `/source'
make: *** [package] Error 2

Steps to reproduce:

$ echo "Name: 50me-P4ck4ge-N4me-W1th-D1g1ts" > test.spec
$ echo "Version: %{version}" >> test.spec
$ echo "Release: 1.%{repo_vendor}%{?dist}" >> test.spec
$ echo "Summary: High performance awesome tool" >> test.spec
$ echo "License: BSD 3-Clause" >> test.spec
$ /usr/bin/rpmspec -P test.spec
error: Too many levels of recursion in macro expansion. It is likely caused by recursive macro declaration.

Old behavior without using rpmspec:

$ sed -n -e 's/Name:\([\ \t]*\)\(.*\)/\2/p' test.spec
50me-P4ck4ge-N4me-W1th-D1g1ts

Refs:

• Red Hat Bugzilla – Bug 613010
• Red Hat Bugzilla – Bug 1475439

[akopytov]

@sergeyklay the first link to RedHat Bugzilla says the reason for recursion is "Version: %{version}", so one should avoid that construct. Which makes even more sense with packpack, since that tag is overridden anyway. Would fixing the spec file instead be a better idea?

[sergeyklay]

@akopytov It seems to me we need at least a "flag" to disable/enable current behavior with rpmspec.