Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce calls to SQLGetDiagRec #280

Merged
merged 1 commit into from Oct 10, 2022
Merged

Conversation

pacman82
Copy link
Owner

Makes sense, even independently from #266. If it turns out it helps poor souls using erroneous drivers, which delete messages then fetching with an empty message buffer as a workaround, thats a plus.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2dd83737ebc62e6f965242d62e0b02dc8d2c5f1b-PR-280

  • 8 of 8 (100.0%) changed or added relevant lines in 3 files are covered.
  • 11 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 83.551%

Files with Coverage Reduction New Missed Lines %
odbc-api/src/handles/diagnostics.rs 11 86.13%
Totals Coverage Status
Change from base Build ab3783668606ab56537df2c472f034672e6c62eb: -0.2%
Covered Lines: 4160
Relevant Lines: 4979

💛 - Coveralls

@pacman82 pacman82 merged commit dd43d93 into main Oct 10, 2022
@pacman82 pacman82 deleted the avoid-repeated-calls-to-SQLGetDiagRec branch November 12, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants