Skip to content

fix: controlled search change with hidden Command.List #234

fix: controlled search change with hidden Command.List

fix: controlled search change with hidden Command.List #234

Triggered via pull request March 8, 2024 18:24
Status Success
Total duration 2m 14s
Artifacts 1

test.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors, 3 warnings, and 1 notice
[webkit] › basic.test.ts:8:7 › basic behavior › input props are forwarded: test/basic.test.ts#L4
1) [webkit] › basic.test.ts:8:7 › basic behavior › input props are forwarded ───────────────────── Test timeout of 5000ms exceeded while running "beforeEach" hook. 2 | 3 | test.describe('basic behavior', async () => { > 4 | test.beforeEach(async ({ page }) => { | ^ 5 | await page.goto('/') 6 | }) 7 | at /home/runner/work/cmdk/cmdk/test/basic.test.ts:4:8
[webkit] › basic.test.ts:8:7 › basic behavior › input props are forwarded: test/basic.test.ts#L5
1) [webkit] › basic.test.ts:8:7 › basic behavior › input props are forwarded ───────────────────── Error: page.goto: Test timeout of 5000ms exceeded. Call log: - navigating to "http://localhost:3000/", waiting until "load" 3 | test.describe('basic behavior', async () => { 4 | test.beforeEach(async ({ page }) => { > 5 | await page.goto('/') | ^ 6 | }) 7 | 8 | test('input props are forwarded', async ({ page }) => { at /home/runner/work/cmdk/cmdk/test/basic.test.ts:5:16
[webkit] › basic.test.ts:23:7 › basic behavior › item onSelect is called on click: test/basic.test.ts#L26
2) [webkit] › basic.test.ts:23:7 › basic behavior › item onSelect is called on click ───────────── Error: expect(received).toEqual(expected) // deep equality Expected: "Item selected" Received: "[HMR] connected" 24 | const item = page.locator(`[cmdk-item][data-value="Item"]`) 25 | const [message] = await Promise.all([page.waitForEvent('console'), item.click()]) > 26 | expect(message.text()).toEqual('Item selected') | ^ 27 | }) 28 | 29 | test('first item is selected by default', async ({ page }) => { at /home/runner/work/cmdk/cmdk/test/basic.test.ts:26:28
[webkit] › basic.test.ts:34:7 › basic behavior › first item is selected when search changes: test/basic.test.ts#L1
3) [webkit] › basic.test.ts:34:7 › basic behavior › first item is selected when search changes ─── Test timeout of 5000ms exceeded.
[webkit] › basic.test.ts:34:7 › basic behavior › first item is selected when search changes: test/basic.test.ts#L38
3) [webkit] › basic.test.ts:34:7 › basic behavior › first item is selected when search changes ─── Error: expect(locator).toHaveText(expected) Locator: locator('[cmdk-item][aria-selected="true"]') Expected string: "Value" Received string: "Item" Call log: - expect.toHaveText with timeout 5000ms - waiting for locator('[cmdk-item][aria-selected="true"]') - locator resolved to <div id=":R5am:" class="item" cmdk-item="" role="opti…>Item</div> - unexpected value "Item" - locator resolved to <div id=":R5am:" class="item" cmdk-item="" role="opti…>Item</div> - unexpected value "Item" - locator resolved to <div id=":R5am:" class="item" cmdk-item="" role="opti…>Item</div> - unexpected value "Item" - locator resolved to <div id=":R5am:" class="item" cmdk-item="" role="opti…>Item</div> - unexpected value "Item" - locator resolved to <div id=":R5am:" class="item" cmdk-item="" role="opti…>Item</div> - unexpected value "Item" - locator resolved to <div id=":R5am:" class="item" cmdk-item="" role="opti…>Item</div> - unexpected value "Item" - locator resolved to <div id=":R5am:" class="item" cmdk-item="" role="opti…>Item</div> - unexpected value "Item" 36 | await input.type('x') 37 | const selected = page.locator(`[cmdk-item][aria-selected="true"]`) > 38 | await expect(selected).toHaveText('Value') | ^ 39 | }) 40 | 41 | test('items filter when searching', async ({ page }) => { at /home/runner/work/cmdk/cmdk/test/basic.test.ts:38:28
[webkit] › basic.test.ts:59:7 › basic behavior › empty component renders when there are no results: test/basic.test.ts#L1
4) [webkit] › basic.test.ts:59:7 › basic behavior › empty component renders when there are no results Test timeout of 5000ms exceeded.
[webkit] › basic.test.ts:59:7 › basic behavior › empty component renders when there are no results: test/basic.test.ts#L62
4) [webkit] › basic.test.ts:59:7 › basic behavior › empty component renders when there are no results Error: expect(locator).toHaveCount(expected) Locator: locator('[cmdk-item]') Expected: 0 Received: 2 Call log: - expect.toHaveCount with timeout 5000ms - waiting for locator('[cmdk-item]') - locator resolved to 2 elements - unexpected value "2" - locator resolved to 2 elements - unexpected value "2" - locator resolved to 2 elements - unexpected value "2" - locator resolved to 2 elements - unexpected value "2" - locator resolved to 2 elements - unexpected value "2" - locator resolved to 2 elements - unexpected value "2" - locator resolved to 2 elements - unexpected value "2" - locator resolved to 2 elements - unexpected value "2" 60 | const input = page.locator('[cmdk-input]') 61 | await input.type('z') > 62 | await expect(page.locator(`[cmdk-item]`)).toHaveCount(0) | ^ 63 | await expect(page.locator(`[cmdk-empty]`)).toHaveText('No results.') 64 | }) 65 | at /home/runner/work/cmdk/cmdk/test/basic.test.ts:62:47
[webkit] › basic.test.ts:66:7 › basic behavior › className is applied to each part: test/basic.test.ts#L1
5) [webkit] › basic.test.ts:66:7 › basic behavior › className is applied to each part ──────────── Test timeout of 5000ms exceeded.
[webkit] › basic.test.ts:66:7 › basic behavior › className is applied to each part: test/basic.test.ts#L72
5) [webkit] › basic.test.ts:66:7 › basic behavior › className is applied to each part ──────────── Error: expect(locator).toHaveCount(expected) Locator: locator('.item') Expected: 0 Received: 2 Call log: - expect.toHaveCount with timeout 5000ms - waiting for locator('.item') - locator resolved to 2 elements - unexpected value "2" - locator resolved to 2 elements - unexpected value "2" - locator resolved to 2 elements - unexpected value "2" - locator resolved to 2 elements - unexpected value "2" - locator resolved to 2 elements - unexpected value "2" - locator resolved to 2 elements - unexpected value "2" - locator resolved to 2 elements - unexpected value "2" - locator resolved to 2 elements - unexpected value "2" 70 | await expect(page.locator(`.item`)).toHaveCount(2) 71 | await page.locator('[cmdk-input]').type('zzzz') > 72 | await expect(page.locator(`.item`)).toHaveCount(0) | ^ 73 | await expect(page.locator(`.empty`)).toHaveCount(1) 74 | }) 75 | }) at /home/runner/work/cmdk/cmdk/test/basic.test.ts:72:41
[webkit] › dialog.test.ts:8:7 › dialog › dialog renders in portal: test/dialog.test.ts#L1
6) [webkit] › dialog.test.ts:8:7 › dialog › dialog renders in portal ───────────────────────────── Test finished within timeout of 5000ms, but tearing down "context" ran out of time. Please allow more time for the test, since teardown is attributed towards the test timeout budget.
🎭 Playwright Run Summary
7 flaky [webkit] › basic.test.ts:8:7 › basic behavior › input props are forwarded ────────────────────── [webkit] › basic.test.ts:23:7 › basic behavior › item onSelect is called on click ────────────── [webkit] › basic.test.ts:34:7 › basic behavior › first item is selected when search changes ──── [webkit] › basic.test.ts:59:7 › basic behavior › empty component renders when there are no results [webkit] › basic.test.ts:66:7 › basic behavior › className is applied to each part ───────────── [webkit] › dialog.test.ts:8:7 › dialog › dialog renders in portal ────────────────────────────── [webkit] › keybind.test.ts:118:7 › no-vim keybinds › ctrl n/p does nothing ───────────────────── 34 passed (46.9s)
test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, pnpm/action-setup@v2, actions/setup-node@v3, actions/upload-artifact@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Slow Test: [webkit] › basic.test.ts#L1
[webkit] › basic.test.ts took 31.0s

Artifacts

Produced during runtime
Name Size
playwright-report Expired
68.6 KB