Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rewrite tests to use renderHook when possible #285

Merged
merged 1 commit into from
Apr 24, 2024
Merged

refactor: rewrite tests to use renderHook when possible #285

merged 1 commit into from
Apr 24, 2024

Conversation

trm217
Copy link
Collaborator

@trm217 trm217 commented Apr 23, 2024 •
edited
Loading

Using render-hook in the tests is far better from a readability perspective imo.
Also it's more concise :)

@trm217 trm217 added the tests label Apr 23, 2024
@trm217 trm217 self-assigned this Apr 23, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-themes-basic ❌ Failed (Inspect) Apr 23, 2024 10:57am
next-themes-tailwind ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 10:57am
next-themes-with-app-dir ❌ Failed (Inspect) Apr 23, 2024 10:57am

@trm217 trm217 requested a review from pacocoursey April 23, 2024 10:57
@trm217 trm217 mentioned this pull request Apr 23, 2024
Merged
@trm217 trm217 merged commit 829d517 into main Apr 24, 2024
4 of 6 checks passed
@trm217 trm217 deleted the test/make-use-of-render-hook branch April 24, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacocoursey pacocoursey pacocoursey approved these changes

Assignees

@trm217 trm217

Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@trm217 @pacocoursey