Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added es.toml #52

Merged
merged 5 commits into from Aug 15, 2019

Conversation

@reymon359
Copy link
Contributor

commented Aug 13, 2019

Description

I translated the en.toml to spanish and added it to the i18n folder.

Motivation and Context

I saw this awesome theme and decided to use it on my personal blog. At first I had not intention to contribute so I made a module as sugested and started changing the main config.toml and stuff in the content. Then I realized I needed a i18n/es.toml file and decided to create it but after adding to the module I could not "push and pull" new changes from the original repo, that's why I decided to make a pull request to the original to add it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

@VincentTam
Copy link
Collaborator

left a comment

Thanks very much ! Gracias ! 😄

@pacollins

This comment has been minimized.

Copy link
Owner

commented Aug 13, 2019

Thanks for this! Can you go ahead and add the following to this? We are still working on the exact wording though.

602bdbc#diff-37fb0a88b36c36c1795ae48027e1edf3

@reymon359

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

I am glad it helped!😄
Sure, I will take a look to this #52 (comment)

@reymon359 reymon359 changed the title added es.toml Added es.toml Aug 14, 2019

@reymon359

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

I added the attribution too. If you need anything else just let me know😊

@VincentTam
Copy link
Collaborator

left a comment

Thanks again for your addition. In response to @pacollins's request to shorten the site footer, this sentence has to be shortened.

P.S. Please avoid missing newline at EOF since this causes unexpected behavior of some command line utilities like wc. When committing online on GitHub, always leave an empty newline to avoid this.

i18n/es.toml Outdated Show resolved Hide resolved
@reymon359

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

New line at EOF added too. Thank you @VincentTam for the advice before!

@VincentTam

This comment has been minimized.

Copy link
Collaborator

commented Aug 14, 2019

@reymon359 Thanks for follow-up. I'll leave it for @pacollins to decide.

@pacollins

This comment has been minimized.

Copy link
Owner

commented Aug 14, 2019

@reymon359 Again, thank you SO much for this PR. It is actually really important to me that we have proper translations. I appologize for having you adjust your PR 1 last time, but I think we have determined the syntax we will use. See this post. Feel free to modify the wordings to optimize the look of the footer (ideally three lines).

reymon359 added some commits Aug 15, 2019

@reymon359

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2019

I like the new syntax you guys came up with, it is much simpler👍.
I adjusted and translated the PR to it while to optimize it to 3 lines.
Here is how it looks on Desktop:
image
And here on Mobile (Chrome browser's Galaxy S5):
image

Changes have been made.

@pacollins pacollins merged commit 6453583 into pacollins:master Aug 15, 2019

1 check passed

AccessLint Review complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.