Skip to content
This repository has been archived by the owner on Apr 5, 2022. It is now read-only.

Added es.toml #52

Merged
merged 5 commits into from Aug 15, 2019
Merged

Added es.toml #52

merged 5 commits into from Aug 15, 2019

Conversation

reymon359
Copy link
Contributor

@reymon359 reymon359 commented Aug 13, 2019

Description

I translated the en.toml to spanish and added it to the i18n folder.

Motivation and Context

I saw this awesome theme and decided to use it on my personal blog. At first I had not intention to contribute so I made a module as sugested and started changing the main config.toml and stuff in the content. Then I realized I needed a i18n/es.toml file and decided to create it but after adding to the module I could not "push and pull" new changes from the original repo, that's why I decided to make a pull request to the original to add it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Copy link
Collaborator

@VincentTam VincentTam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much ! Gracias ! 😄

@pacollins
Copy link
Owner

pacollins commented Aug 13, 2019

Thanks for this! Can you go ahead and add the following to this? We are still working on the exact wording though.

602bdbc#diff-37fb0a88b36c36c1795ae48027e1edf3

@reymon359
Copy link
Contributor Author

reymon359 commented Aug 14, 2019

I am glad it helped!😄
Sure, I will take a look to this #52 (comment)

@reymon359 reymon359 changed the title added es.toml Added es.toml Aug 14, 2019
@reymon359
Copy link
Contributor Author

I added the attribution too. If you need anything else just let me know😊

Copy link
Collaborator

@VincentTam VincentTam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your addition. In response to @pacollins's request to shorten the site footer, this sentence has to be shortened.

P.S. Please avoid missing newline at EOF since this causes unexpected behavior of some command line utilities like wc. When committing online on GitHub, always leave an empty newline to avoid this.

i18n/es.toml Outdated Show resolved Hide resolved
@reymon359
Copy link
Contributor Author

New line at EOF added too. Thank you @VincentTam for the advice before!

@VincentTam
Copy link
Collaborator

@reymon359 Thanks for follow-up. I'll leave it for @pacollins to decide.

@pacollins
Copy link
Owner

@reymon359 Again, thank you SO much for this PR. It is actually really important to me that we have proper translations. I appologize for having you adjust your PR 1 last time, but I think we have determined the syntax we will use. See this post. Feel free to modify the wordings to optimize the look of the footer (ideally three lines).

@reymon359
Copy link
Contributor Author

I like the new syntax you guys came up with, it is much simpler👍.
I adjusted and translated the PR to it while to optimize it to 3 lines.
Here is how it looks on Desktop:
image
And here on Mobile (Chrome browser's Galaxy S5):
image

@pacollins pacollins dismissed VincentTam’s stale review August 15, 2019 23:19

Changes have been made.

@pacollins pacollins merged commit 6453583 into pacollins:master Aug 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants