Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much ! Gracias ! 😄
Thanks for this! Can you go ahead and add the following to this? We are still working on the exact wording though. |
I am glad it helped!😄 |
I added the attribution too. If you need anything else just let me know😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your addition. In response to @pacollins's request to shorten the site footer, this sentence has to be shortened.
P.S. Please avoid missing newline at EOF since this causes unexpected behavior of some command line utilities like wc
. When committing online on GitHub, always leave an empty newline to avoid this.
New line at EOF added too. Thank you @VincentTam for the advice before! |
@reymon359 Thanks for follow-up. I'll leave it for @pacollins to decide. |
@reymon359 Again, thank you SO much for this PR. It is actually really important to me that we have proper translations. I appologize for having you adjust your PR 1 last time, but I think we have determined the syntax we will use. See this post. Feel free to modify the wordings to optimize the look of the footer (ideally three lines). |
Description
I translated the en.toml to spanish and added it to the i18n folder.
Motivation and Context
I saw this awesome theme and decided to use it on my personal blog. At first I had not intention to contribute so I made a module as sugested and started changing the main config.toml and stuff in the content. Then I realized I needed a i18n/es.toml file and decided to create it but after adding to the module I could not "push and pull" new changes from the original repo, that's why I decided to make a pull request to the original to add it.
Types of changes
Checklist:
theme.toml
, accordingly.