hotfix(1.6.1): Minor bug fixes #315

D-Brox · 2021-10-16T22:00:59Z

Purpose

Hotfixes for 1.6 release

Progress

build_depends uninstall not working
postrm ask function backwards compatibility
Failing to reinstall when $breaks is the same as $name
Edit pacscript priviledges

Addendum

#313

Checklist

I confirm that I have read the contributing guidelines, and this pull request is abiding by all the clauses stated in the guideline.

I also moved the ppa thingy before all apt installs

misc/scripts/install-local.sh

* add(ci): workflow script * chan(ci): script link * chan(ci): script link * Update remote-bash.yml * fix(ci-script): rm axel * fix(ci): missing -y * Fix(ci): use install script * fix(ci): chown * Update workflow.sh * Update remote-bash.yml

Elsie19 · 2021-10-20T12:58:15Z

ready @D-Brox?

misc/scripts/download.sh

* Fix(update): missing `mkdir` (#317) * hotfix(1.6.1): Minor bug fixes (#315) * Fix(install): build_depends removal * Fix(install): build_depends extra spaces and correct install * Fix(install): Wrong comparison I also moved the ppa thingy before all apt installs * Fix(install): if `$breaks` is equal to `$name` * Fix(install): postrm `ask` return code * Fix(install): build_depends auto removal * Fix(install): edit with elevated priviledges * Fix(download): reduce priviledges * Fix(install): reduce priviledges on the pacscript * Fix(install): breaks is a list * Fix(install): remove unused if * Fix(install): ignore pacstall installed dpkg-query * FIx(install): typos * FIx(install): `then` -> `do` * Bump version * feat(github): Move workflow script here (#316) * add(ci): workflow script * chan(ci): script link * chan(ci): script link * Update remote-bash.yml * fix(ci-script): rm axel * fix(ci): missing -y * Fix(ci): use install script * fix(ci): chown * Update workflow.sh * Update remote-bash.yml * Fix(install): codacy fix * Ref(CI):change branch Co-authored-by: The TwilightBlood <hwengerstickel@protonmail.com> Co-authored-by: Naruto Uzumaki <79555780+NarutoXY@users.noreply.github.com> * Ref(README): fix badges (#320) Co-authored-by: The TwilightBlood <hwengerstickel@protonmail.com> Co-authored-by: Naruto Uzumaki <79555780+NarutoXY@users.noreply.github.com>

* Fix(update): missing `mkdir` (#317) * hotfix(1.6.1): Minor bug fixes (#315) * Fix(install): build_depends removal * Fix(install): build_depends extra spaces and correct install * Fix(install): Wrong comparison I also moved the ppa thingy before all apt installs * Fix(install): if `$breaks` is equal to `$name` * Fix(install): postrm `ask` return code * Fix(install): build_depends auto removal * Fix(install): edit with elevated priviledges * Fix(download): reduce priviledges * Fix(install): reduce priviledges on the pacscript * Fix(install): breaks is a list * Fix(install): remove unused if * Fix(install): ignore pacstall installed dpkg-query * FIx(install): typos * FIx(install): `then` -> `do` * Bump version * feat(github): Move workflow script here (#316) * add(ci): workflow script * chan(ci): script link * chan(ci): script link * Update remote-bash.yml * fix(ci-script): rm axel * fix(ci): missing -y * Fix(ci): use install script * fix(ci): chown * Update workflow.sh * Update remote-bash.yml * Fix(install): codacy fix * Ref(CI):change branch Co-authored-by: The TwilightBlood <hwengerstickel@protonmail.com> Co-authored-by: Naruto Uzumaki <79555780+NarutoXY@users.noreply.github.com> * Ref(README): fix badges (#320) * Fix(install): `/tmp/pacstall` permissions Co-authored-by: The TwilightBlood <hwengerstickel@protonmail.com> Co-authored-by: Naruto Uzumaki <79555780+NarutoXY@users.noreply.github.com>

* Fix(update): missing `mkdir` (#317) * hotfix(1.6.1): Minor bug fixes (#315) * Fix(install): build_depends removal * Fix(install): build_depends extra spaces and correct install * Fix(install): Wrong comparison I also moved the ppa thingy before all apt installs * Fix(install): if `$breaks` is equal to `$name` * Fix(install): postrm `ask` return code * Fix(install): build_depends auto removal * Fix(install): edit with elevated priviledges * Fix(download): reduce priviledges * Fix(install): reduce priviledges on the pacscript * Fix(install): breaks is a list * Fix(install): remove unused if * Fix(install): ignore pacstall installed dpkg-query * FIx(install): typos * FIx(install): `then` -> `do` * Bump version * feat(github): Move workflow script here (#316) * add(ci): workflow script * chan(ci): script link * chan(ci): script link * Update remote-bash.yml * fix(ci-script): rm axel * fix(ci): missing -y * Fix(ci): use install script * fix(ci): chown * Update workflow.sh * Update remote-bash.yml * Fix(install): codacy fix * Ref(CI):change branch Co-authored-by: The TwilightBlood <hwengerstickel@protonmail.com> Co-authored-by: Naruto Uzumaki <79555780+NarutoXY@users.noreply.github.com> * Ref(README): fix badges (#320) * Fix(install): `/tmp/pacstall` permissions * fix(workflow,installer): Add method to skip network check (#323) * fix(workflow,installer): add environmental variable to skip internet check * Rename skip network check * Change workflow to skip network check * ref(ci): Remove duplicate dependency install Co-authored-by: Sourajyoti Basak <wiz28@protonmail.com> * fix(install-local): Cleanup on function fails (#325) * Fix(install): cleanup on function fails * Fix(install): missing `fi` Co-authored-by: The TwilightBlood <hwengerstickel@protonmail.com> Co-authored-by: Naruto Uzumaki <79555780+NarutoXY@users.noreply.github.com> Co-authored-by: Sourajyoti Basak <wiz28@protonmail.com>

* Fix(install): build_depends removal * Fix(install): build_depends extra spaces and correct install * Fix(install): Wrong comparison I also moved the ppa thingy before all apt installs * Fix(install): if `$breaks` is equal to `$name` * Fix(install): postrm `ask` return code * Fix(install): build_depends auto removal * Fix(install): edit with elevated priviledges * Fix(download): reduce priviledges * Fix(install): reduce priviledges on the pacscript * Fix(install): breaks is a list * Fix(install): remove unused if * Fix(install): ignore pacstall installed dpkg-query * FIx(install): typos * FIx(install): `then` -> `do` * Bump version * feat(github): Move workflow script here (#316) * add(ci): workflow script * chan(ci): script link * chan(ci): script link * Update remote-bash.yml * fix(ci-script): rm axel * fix(ci): missing -y * Fix(ci): use install script * fix(ci): chown * Update workflow.sh * Update remote-bash.yml * Fix(install): codacy fix * Ref(CI):change branch Co-authored-by: The TwilightBlood <hwengerstickel@protonmail.com> Co-authored-by: Naruto Uzumaki <79555780+NarutoXY@users.noreply.github.com> Former-commit-id: 96ebe91

* Fix(update): missing `mkdir` (#317) * hotfix(1.6.1): Minor bug fixes (#315) * Fix(install): build_depends removal * Fix(install): build_depends extra spaces and correct install * Fix(install): Wrong comparison I also moved the ppa thingy before all apt installs * Fix(install): if `$breaks` is equal to `$name` * Fix(install): postrm `ask` return code * Fix(install): build_depends auto removal * Fix(install): edit with elevated priviledges * Fix(download): reduce priviledges * Fix(install): reduce priviledges on the pacscript * Fix(install): breaks is a list * Fix(install): remove unused if * Fix(install): ignore pacstall installed dpkg-query * FIx(install): typos * FIx(install): `then` -> `do` * Bump version * feat(github): Move workflow script here (#316) * add(ci): workflow script * chan(ci): script link * chan(ci): script link * Update remote-bash.yml * fix(ci-script): rm axel * fix(ci): missing -y * Fix(ci): use install script * fix(ci): chown * Update workflow.sh * Update remote-bash.yml * Fix(install): codacy fix * Ref(CI):change branch Co-authored-by: The TwilightBlood <hwengerstickel@protonmail.com> Co-authored-by: Naruto Uzumaki <79555780+NarutoXY@users.noreply.github.com> * Ref(README): fix badges (#320) Co-authored-by: The TwilightBlood <hwengerstickel@protonmail.com> Co-authored-by: Naruto Uzumaki <79555780+NarutoXY@users.noreply.github.com> Former-commit-id: 44d7cad

* Fix(update): missing `mkdir` (#317) * hotfix(1.6.1): Minor bug fixes (#315) * Fix(install): build_depends removal * Fix(install): build_depends extra spaces and correct install * Fix(install): Wrong comparison I also moved the ppa thingy before all apt installs * Fix(install): if `$breaks` is equal to `$name` * Fix(install): postrm `ask` return code * Fix(install): build_depends auto removal * Fix(install): edit with elevated priviledges * Fix(download): reduce priviledges * Fix(install): reduce priviledges on the pacscript * Fix(install): breaks is a list * Fix(install): remove unused if * Fix(install): ignore pacstall installed dpkg-query * FIx(install): typos * FIx(install): `then` -> `do` * Bump version * feat(github): Move workflow script here (#316) * add(ci): workflow script * chan(ci): script link * chan(ci): script link * Update remote-bash.yml * fix(ci-script): rm axel * fix(ci): missing -y * Fix(ci): use install script * fix(ci): chown * Update workflow.sh * Update remote-bash.yml * Fix(install): codacy fix * Ref(CI):change branch Co-authored-by: The TwilightBlood <hwengerstickel@protonmail.com> Co-authored-by: Naruto Uzumaki <79555780+NarutoXY@users.noreply.github.com> * Ref(README): fix badges (#320) * Fix(install): `/tmp/pacstall` permissions Co-authored-by: The TwilightBlood <hwengerstickel@protonmail.com> Co-authored-by: Naruto Uzumaki <79555780+NarutoXY@users.noreply.github.com> Former-commit-id: 2ae3ca7

* Fix(install): build_depends removal * Fix(install): build_depends extra spaces and correct install * Fix(install): Wrong comparison I also moved the ppa thingy before all apt installs * Fix(install): if `$breaks` is equal to `$name` * Fix(install): postrm `ask` return code * Fix(install): build_depends auto removal * Fix(install): edit with elevated priviledges * Fix(download): reduce priviledges * Fix(install): reduce priviledges on the pacscript * Fix(install): breaks is a list * Fix(install): remove unused if * Fix(install): ignore pacstall installed dpkg-query * FIx(install): typos * FIx(install): `then` -> `do` * Bump version * feat(github): Move workflow script here (#316) * add(ci): workflow script * chan(ci): script link * chan(ci): script link * Update remote-bash.yml * fix(ci-script): rm axel * fix(ci): missing -y * Fix(ci): use install script * fix(ci): chown * Update workflow.sh * Update remote-bash.yml * Fix(install): codacy fix * Ref(CI):change branch Co-authored-by: The TwilightBlood <hwengerstickel@protonmail.com> Co-authored-by: Naruto Uzumaki <79555780+NarutoXY@users.noreply.github.com> Former-commit-id: d67c68b [formerly 96ebe91] Former-commit-id: 30082ef

* Fix(update): missing `mkdir` (#317) * hotfix(1.6.1): Minor bug fixes (#315) * Fix(install): build_depends removal * Fix(install): build_depends extra spaces and correct install * Fix(install): Wrong comparison I also moved the ppa thingy before all apt installs * Fix(install): if `$breaks` is equal to `$name` * Fix(install): postrm `ask` return code * Fix(install): build_depends auto removal * Fix(install): edit with elevated priviledges * Fix(download): reduce priviledges * Fix(install): reduce priviledges on the pacscript * Fix(install): breaks is a list * Fix(install): remove unused if * Fix(install): ignore pacstall installed dpkg-query * FIx(install): typos * FIx(install): `then` -> `do` * Bump version * feat(github): Move workflow script here (#316) * add(ci): workflow script * chan(ci): script link * chan(ci): script link * Update remote-bash.yml * fix(ci-script): rm axel * fix(ci): missing -y * Fix(ci): use install script * fix(ci): chown * Update workflow.sh * Update remote-bash.yml * Fix(install): codacy fix * Ref(CI):change branch Co-authored-by: The TwilightBlood <hwengerstickel@protonmail.com> Co-authored-by: Naruto Uzumaki <79555780+NarutoXY@users.noreply.github.com> * Ref(README): fix badges (#320) Co-authored-by: The TwilightBlood <hwengerstickel@protonmail.com> Co-authored-by: Naruto Uzumaki <79555780+NarutoXY@users.noreply.github.com> Former-commit-id: ea48a13 [formerly 44d7cad] Former-commit-id: 890f170

* Fix(update): missing `mkdir` (pacstall#317) * hotfix(1.6.1): Minor bug fixes (pacstall#315) * Fix(install): build_depends removal * Fix(install): build_depends extra spaces and correct install * Fix(install): Wrong comparison I also moved the ppa thingy before all apt installs * Fix(install): if `$breaks` is equal to `$name` * Fix(install): postrm `ask` return code * Fix(install): build_depends auto removal * Fix(install): edit with elevated priviledges * Fix(download): reduce priviledges * Fix(install): reduce priviledges on the pacscript * Fix(install): breaks is a list * Fix(install): remove unused if * Fix(install): ignore pacstall installed dpkg-query * FIx(install): typos * FIx(install): `then` -> `do` * Bump version * feat(github): Move workflow script here (pacstall#316) * add(ci): workflow script * chan(ci): script link * chan(ci): script link * Update remote-bash.yml * fix(ci-script): rm axel * fix(ci): missing -y * Fix(ci): use install script * fix(ci): chown * Update workflow.sh * Update remote-bash.yml * Fix(install): codacy fix * Ref(CI):change branch Co-authored-by: The TwilightBlood <hwengerstickel@protonmail.com> Co-authored-by: Naruto Uzumaki <79555780+NarutoXY@users.noreply.github.com> * Ref(README): fix badges (pacstall#320) * Fix(install): `/tmp/pacstall` permissions Co-authored-by: The TwilightBlood <hwengerstickel@protonmail.com> Co-authored-by: Naruto Uzumaki <79555780+NarutoXY@users.noreply.github.com> Former-commit-id: 3d76bcf [formerly 2ae3ca7] Former-commit-id: a23e175

* Fix(install): build_depends removal * Fix(install): build_depends extra spaces and correct install * Fix(install): Wrong comparison I also moved the ppa thingy before all apt installs * Fix(install): if `$breaks` is equal to `$name` * Fix(install): postrm `ask` return code * Fix(install): build_depends auto removal * Fix(install): edit with elevated priviledges * Fix(download): reduce priviledges * Fix(install): reduce priviledges on the pacscript * Fix(install): breaks is a list * Fix(install): remove unused if * Fix(install): ignore pacstall installed dpkg-query * FIx(install): typos * FIx(install): `then` -> `do` * Bump version * feat(github): Move workflow script here (#316) * add(ci): workflow script * chan(ci): script link * chan(ci): script link * Update remote-bash.yml * fix(ci-script): rm axel * fix(ci): missing -y * Fix(ci): use install script * fix(ci): chown * Update workflow.sh * Update remote-bash.yml * Fix(install): codacy fix * Ref(CI):change branch Co-authored-by: The TwilightBlood <hwengerstickel@protonmail.com> Co-authored-by: Naruto Uzumaki <79555780+NarutoXY@users.noreply.github.com> Former-commit-id: 96ebe91

* Fix(update): missing `mkdir` (#317) * hotfix(1.6.1): Minor bug fixes (#315) * Fix(install): build_depends removal * Fix(install): build_depends extra spaces and correct install * Fix(install): Wrong comparison I also moved the ppa thingy before all apt installs * Fix(install): if `$breaks` is equal to `$name` * Fix(install): postrm `ask` return code * Fix(install): build_depends auto removal * Fix(install): edit with elevated priviledges * Fix(download): reduce priviledges * Fix(install): reduce priviledges on the pacscript * Fix(install): breaks is a list * Fix(install): remove unused if * Fix(install): ignore pacstall installed dpkg-query * FIx(install): typos * FIx(install): `then` -> `do` * Bump version * feat(github): Move workflow script here (#316) * add(ci): workflow script * chan(ci): script link * chan(ci): script link * Update remote-bash.yml * fix(ci-script): rm axel * fix(ci): missing -y * Fix(ci): use install script * fix(ci): chown * Update workflow.sh * Update remote-bash.yml * Fix(install): codacy fix * Ref(CI):change branch Co-authored-by: The TwilightBlood <hwengerstickel@protonmail.com> Co-authored-by: Naruto Uzumaki <79555780+NarutoXY@users.noreply.github.com> * Ref(README): fix badges (#320) Co-authored-by: The TwilightBlood <hwengerstickel@protonmail.com> Co-authored-by: Naruto Uzumaki <79555780+NarutoXY@users.noreply.github.com> Former-commit-id: 44d7cad

* Fix(update): missing `mkdir` (#317) * hotfix(1.6.1): Minor bug fixes (#315) * Fix(install): build_depends removal * Fix(install): build_depends extra spaces and correct install * Fix(install): Wrong comparison I also moved the ppa thingy before all apt installs * Fix(install): if `$breaks` is equal to `$name` * Fix(install): postrm `ask` return code * Fix(install): build_depends auto removal * Fix(install): edit with elevated priviledges * Fix(download): reduce priviledges * Fix(install): reduce priviledges on the pacscript * Fix(install): breaks is a list * Fix(install): remove unused if * Fix(install): ignore pacstall installed dpkg-query * FIx(install): typos * FIx(install): `then` -> `do` * Bump version * feat(github): Move workflow script here (#316) * add(ci): workflow script * chan(ci): script link * chan(ci): script link * Update remote-bash.yml * fix(ci-script): rm axel * fix(ci): missing -y * Fix(ci): use install script * fix(ci): chown * Update workflow.sh * Update remote-bash.yml * Fix(install): codacy fix * Ref(CI):change branch Co-authored-by: The TwilightBlood <hwengerstickel@protonmail.com> Co-authored-by: Naruto Uzumaki <79555780+NarutoXY@users.noreply.github.com> * Ref(README): fix badges (#320) * Fix(install): `/tmp/pacstall` permissions Co-authored-by: The TwilightBlood <hwengerstickel@protonmail.com> Co-authored-by: Naruto Uzumaki <79555780+NarutoXY@users.noreply.github.com> Former-commit-id: 2ae3ca7

D-Brox added 12 commits October 16, 2021 18:03

Fix(install): build_depends removal

3cd8ebb

Fix(install): build_depends extra spaces and correct install

3c78698

Fix(install): Wrong comparison

fbd5e86

I also moved the ppa thingy before all apt installs

Fix(install): if $breaks is equal to $name

8fa2d2d

Fix(install): postrm ask return code

4f7a3b4

Fix(install): build_depends auto removal

150bbaa

Fix(install): edit with elevated priviledges

33bd0ad

Fix(download): reduce priviledges

d328eea

Fix(install): reduce priviledges on the pacscript

cb14266

Fix(install): breaks is a list

e5b3001

Fix(install): remove unused if

8f56bf2

Fix(install): ignore pacstall installed dpkg-query

b34ef61

Elsie19 reviewed Oct 17, 2021

View reviewed changes

misc/scripts/install-local.sh Outdated Show resolved Hide resolved

D-Brox and others added 3 commits October 17, 2021 12:27

FIx(install): typos

39f26d3

FIx(install): then -> do

eea8e03

Bump version

b0408bb

Elsie19 approved these changes Oct 17, 2021

View reviewed changes

0oAstro and others added 2 commits October 18, 2021 13:02

Fix(install): codacy fix

087667f

D-Brox marked this pull request as ready for review October 18, 2021 14:42

D-Brox requested review from 0oAstro and wizard-28 as code owners October 18, 2021 14:42

Ref(CI):change branch

bc668a1

Elsie19 approved these changes Oct 20, 2021

View reviewed changes

wizard-28 reviewed Oct 20, 2021

View reviewed changes

misc/scripts/download.sh Show resolved Hide resolved

wizard-28 approved these changes Oct 20, 2021

View reviewed changes

wizard-28 changed the title ~~Hotfix(1.6): Minor bug fixes~~ hotfix(1.6.1): Minor bug fixes Oct 20, 2021

D-Brox merged commit 96ebe91 into develop Oct 20, 2021

D-Brox deleted the 1.6-hotfix branch October 20, 2021 18:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

hotfix(1.6.1): Minor bug fixes #315

hotfix(1.6.1): Minor bug fixes #315

D-Brox commented Oct 16, 2021 •

edited by Elsie19

Elsie19 commented Oct 20, 2021 •

edited

hotfix(1.6.1): Minor bug fixes #315

hotfix(1.6.1): Minor bug fixes #315

Conversation

D-Brox commented Oct 16, 2021 • edited by Elsie19

Purpose

Progress

Addendum

Checklist

Elsie19 commented Oct 20, 2021 • edited

D-Brox commented Oct 16, 2021 •

edited by Elsie19

Elsie19 commented Oct 20, 2021 •

edited