-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(search): fail out on no package #504
Conversation
I think we've discussed this 2 times prior, and I seem to have forgotten why we went with return. |
|
@henryws this is going stale. |
Give me one more week to finish this PR. |
@wizard-28 ready. |
* fix(search): fail out on no package * fix(search): add exits where they should be Former-commit-id: 809540f
Purpose
Currently
search.sh
usesreturn
instead ofexit
to signify a non existent package, but that doesn't work, which gives an exit code of zero instead of one.Approach
Replace certain
return
s withexit
sChecklist