Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install-local): error out if optdepends has no description #508

Merged
merged 1 commit into from
Feb 25, 2022
Merged

fix(install-local): error out if optdepends has no description #508

merged 1 commit into from
Feb 25, 2022

Conversation

Elsie19
Copy link
Member

@Elsie19 Elsie19 commented Feb 24, 2022

Purpose

Fail if optdepends key's do not have a description, and cut to correct character.

Approach

Check the keys with a for loop.

Addendum

Fixes #507

Checklist

  • I confirm that I have read the contributing guidelines, and this pull request is abiding by all the clauses stated in the guideline.

@Elsie19 Elsie19 added bash For the bash version of Pacstall bug Something isn't working release notes Something that is or should be mentioned in the release notes labels Feb 24, 2022
@wizard-28 wizard-28 merged commit 4f23b94 into pacstall:develop Feb 25, 2022
@wizard-28 wizard-28 changed the title fix(install-local): error out if optdepends has no description fix(install-local): error out if optdepends has no description Feb 25, 2022
D-Brox pushed a commit that referenced this pull request Mar 1, 2023
D-Brox pushed a commit to D-Brox/pacstall that referenced this pull request Mar 1, 2023
…stall#508)

Former-commit-id: e90675e6cdb00ef1df20ea69cd2a78034dc0f1a6 [formerly 4f23b94]
Former-commit-id: ff510d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bash For the bash version of Pacstall bug Something isn't working release notes Something that is or should be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pacstall skips the last letter of the last dependency specified in the optdepends list
3 participants