Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow multiple fields in gives #526

Merged
merged 8 commits into from
Mar 29, 2022
Merged

fix: allow multiple fields in gives #526

merged 8 commits into from
Mar 29, 2022

Conversation

Elsie19
Copy link
Member

@Elsie19 Elsie19 commented Mar 21, 2022

Purpose

As it turns out, gives (Provides in the deb) can have multiple fields.

Checklist

  • I confirm that I have read the contributing guidelines, and this pull request is abiding by all the clauses stated in the guideline.

@Elsie19 Elsie19 assigned Elsie19 and unassigned Elsie19 Mar 21, 2022
@Elsie19 Elsie19 added bug Something isn't working bash For the bash version of Pacstall labels Mar 21, 2022
Copy link
Member

@wizard-28 wizard-28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix codacy issue, and I'll let @D-Brox handle this.

@wizard-28 wizard-28 force-pushed the develop branch 2 times, most recently from b1340ef to eebaa43 Compare March 23, 2022 04:34
Copy link
Contributor

@D-Brox D-Brox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the same on the log function

@wizard-28 wizard-28 merged commit db7206e into pacstall:develop Mar 29, 2022
@Elsie19 Elsie19 deleted the gives_fields branch March 29, 2022 22:13
D-Brox pushed a commit that referenced this pull request Mar 1, 2023
* fix: remove inaccurate package count and reword "auto updates"

* fix: better wording for git section

Co-authored-by: Sourajyoti Basak <wiz28@protonmail.com>

* fix: allow multiple fields in gives

* fix: use proper printf syntax

Co-authored-by: Sourajyoti Basak <wiz28@protonmail.com>
Former-commit-id: db7206e
D-Brox pushed a commit that referenced this pull request Mar 1, 2023
* fix: remove inaccurate package count and reword "auto updates"

* fix: better wording for git section

Co-authored-by: Sourajyoti Basak <wiz28@protonmail.com>

* fix: allow multiple fields in gives

* fix: use proper printf syntax

Co-authored-by: Sourajyoti Basak <wiz28@protonmail.com>
Former-commit-id: cef44a2b7c6be5eb79e20e182a7d7c214f50b013 [formerly db7206e]
Former-commit-id: e4e8e39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bash For the bash version of Pacstall bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants