-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(install-local): download patches before downloading package #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wizard-28
added
bug
Something isn't working
bash
For the bash version of Pacstall
labels
Mar 23, 2022
Elsie19
approved these changes
Mar 24, 2022
D-Brox
pushed a commit
to D-Brox/pacstall
that referenced
this pull request
Mar 24, 2022
wizard-28
added a commit
that referenced
this pull request
Mar 29, 2022
#531) * fix(install-local): filter optdepends and install * fix(install-local): description error before asking * fix(install-local): unset temp variables * style(install-local): remove trailling ` ` and `;` * style(install-local): remove extra `"` * fix(install-local): download patches before downloading package (#530) * meta(bug-report): split `os` and `pacstall` versions * meta(feature-request): add `wizard-28` as assignee * fix(install-local): avoid `suggests` recursive behaviour * fix(install-local): codacy issues * fix(install-local): match only words with grep * style(install-local): add missing space Co-authored-by: The TwilightBlood <hwengerstickel@protonmail.com> * fix(install-local): don't overwrite `$depends` * fix(install-local): fix codacy issues Once again Co-authored-by: Sourajyoti Basak <wiz28@protonmail.com> Co-authored-by: The TwilightBlood <hwengerstickel@protonmail.com>
D-Brox
pushed a commit
that referenced
this pull request
Mar 1, 2023
D-Brox
added a commit
that referenced
this pull request
Mar 1, 2023
#531) * fix(install-local): filter optdepends and install * fix(install-local): description error before asking * fix(install-local): unset temp variables * style(install-local): remove trailling ` ` and `;` * style(install-local): remove extra `"` * fix(install-local): download patches before downloading package (#530) * meta(bug-report): split `os` and `pacstall` versions * meta(feature-request): add `wizard-28` as assignee * fix(install-local): avoid `suggests` recursive behaviour * fix(install-local): codacy issues * fix(install-local): match only words with grep * style(install-local): add missing space Co-authored-by: The TwilightBlood <hwengerstickel@protonmail.com> * fix(install-local): don't overwrite `$depends` * fix(install-local): fix codacy issues Once again Co-authored-by: Sourajyoti Basak <wiz28@protonmail.com> Co-authored-by: The TwilightBlood <hwengerstickel@protonmail.com> Former-commit-id: 5dfc254
D-Brox
pushed a commit
to D-Brox/pacstall
that referenced
this pull request
Mar 1, 2023
D-Brox
added a commit
to D-Brox/pacstall
that referenced
this pull request
Mar 1, 2023
pacstall#531) * fix(install-local): filter optdepends and install * fix(install-local): description error before asking * fix(install-local): unset temp variables * style(install-local): remove trailling ` ` and `;` * style(install-local): remove extra `"` * fix(install-local): download patches before downloading package (pacstall#530) * meta(bug-report): split `os` and `pacstall` versions * meta(feature-request): add `wizard-28` as assignee * fix(install-local): avoid `suggests` recursive behaviour * fix(install-local): codacy issues * fix(install-local): match only words with grep * style(install-local): add missing space Co-authored-by: The TwilightBlood <hwengerstickel@protonmail.com> * fix(install-local): don't overwrite `$depends` * fix(install-local): fix codacy issues Once again Co-authored-by: Sourajyoti Basak <wiz28@protonmail.com> Co-authored-by: The TwilightBlood <hwengerstickel@protonmail.com> Former-commit-id: 934ecebc3bbe03c5002841ad36ea04b747df5177 [formerly 5dfc254] Former-commit-id: 20654be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #512
Approach
Move the patch downloader above the package downloader
Checklist