feat: support for local repos #601

D-Brox · 2022-06-12T17:07:29Z

Purpose

Add support for locally hosted repos

Approach

Use curl instead of wget due to it's file:// protocol support. Format path in add-repo when adding local repos.

Checklist

I confirm that I have read the contributing guidelines, and this pull request is abiding by all the clauses stated in the guideline.

for more information, see https://pre-commit.ci

Elsie19

If a secondary repo is misconfigured, operations like install and download fail.

Make sure to allow properly configured repos to work even if a misconfigured one exists. Add a warning about the misconfigured one

…into feat/local-repos

for more information, see https://pre-commit.ci

pacstall

Elsie19

misc/scripts/search.sh

Elsie19

The showed text for local repos should be something like /home/henry/local-repo-pacstall-test, instead of having the file:// in front of it

Elsie19

This @ should not be the same color as the repo

misc/scripts/download.sh

Elsie19

Yet the repo does exist. This error also happens with URLs as well

misc/scripts/add-repo.sh

misc/scripts/download.sh

Co-authored-by: Sourajyoti Basak <wiz28@protonmail.com>

pacstall

Co-authored-by: Sourajyoti Basak <wiz28@protonmail.com>

wizard-28

If the repository is deleted without prior removal from the repolist, then it should warn the user about it, in all commands related to the package repos

It doesn't do that currently

wizard-28

~ expansion doesn't work

wizard-28

Fix the sed error
Link up the blue path to pacstallrepo.txt so that people can open that file by clicking the link on supported terminals

* feat(scripts): local repo support * feat(add-repo): format local repo * fix(add-repo): hide curl test output * fix(add-repo): hide curl test output again * fix(add-repo): Add success message * fix(main): url check on local file * fix(main): missing `;` * fix(download): curl output to file * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * feat(search): add `file://` and warning * fix(search,main): error/warn messages * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix(search): add path cases * fix(search): replace backticks * fix(search): replace single quotes * fix(search): local repo formatting * sty(search): change color of `@` * Update misc/scripts/download.sh Co-authored-by: Plasma <hwengerstickel@protonmail.com> * fix(search): specifyRepo path formatting * fix(search): rework path parsing * style(search): add missing space Co-authored-by: Plasma <hwengerstickel@protonmail.com> * fix(search): add missing `*` * fix(search): readlink doesn't replace `~/` * fix(search): add missing `*`, again * chore(misc): pre-commit hooks * fix(add-repo): follow redirects Co-authored-by: Sourajyoti Basak <wiz28@protonmail.com> * fix(download): follow redirects Co-authored-by: Sourajyoti Basak <wiz28@protonmail.com> * fix(search): `file://` check before github/gitlab * fix(main): follow redirects Co-authored-by: Sourajyoti Basak <wiz28@protonmail.com> * fix(main): check file and return false * fix(search): warn ask once * fix(search): extra replace $HOME case * feat(search): link `repolist.txt` on supported terminals * fix(search): suppress sed error Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Plasma <hwengerstickel@protonmail.com> Co-authored-by: Sourajyoti Basak <wiz28@protonmail.com> Former-commit-id: c996540

* feat(scripts): local repo support * feat(add-repo): format local repo * fix(add-repo): hide curl test output * fix(add-repo): hide curl test output again * fix(add-repo): Add success message * fix(main): url check on local file * fix(main): missing `;` * fix(download): curl output to file * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * feat(search): add `file://` and warning * fix(search,main): error/warn messages * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix(search): add path cases * fix(search): replace backticks * fix(search): replace single quotes * fix(search): local repo formatting * sty(search): change color of `@` * Update misc/scripts/download.sh Co-authored-by: Plasma <hwengerstickel@protonmail.com> * fix(search): specifyRepo path formatting * fix(search): rework path parsing * style(search): add missing space Co-authored-by: Plasma <hwengerstickel@protonmail.com> * fix(search): add missing `*` * fix(search): readlink doesn't replace `~/` * fix(search): add missing `*`, again * chore(misc): pre-commit hooks * fix(add-repo): follow redirects Co-authored-by: Sourajyoti Basak <wiz28@protonmail.com> * fix(download): follow redirects Co-authored-by: Sourajyoti Basak <wiz28@protonmail.com> * fix(search): `file://` check before github/gitlab * fix(main): follow redirects Co-authored-by: Sourajyoti Basak <wiz28@protonmail.com> * fix(main): check file and return false * fix(search): warn ask once * fix(search): extra replace $HOME case * feat(search): link `repolist.txt` on supported terminals * fix(search): suppress sed error Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Plasma <hwengerstickel@protonmail.com> Co-authored-by: Sourajyoti Basak <wiz28@protonmail.com> Former-commit-id: ef6727c186442186313a6b5f48ecf4eb7a732d98 [formerly c996540] Former-commit-id: 1ccce06

D-Brox added 8 commits June 12, 2022 12:39

feat(scripts): local repo support

e994c14

feat(add-repo): format local repo

1275d69

fix(add-repo): hide curl test output

3473123

fix(add-repo): hide curl test output again

b4ff20d

fix(add-repo): Add success message

ff4175d

fix(main): url check on local file

8c29077

fix(main): missing ;

4f84e41

fix(download): curl output to file

ebb3f86

D-Brox requested review from Elsie19, wizard-28 and 0oAstro as code owners June 12, 2022 17:07

[pre-commit.ci] auto fixes from pre-commit.com hooks

b23aae7

for more information, see https://pre-commit.ci

Elsie19 requested changes Jun 14, 2022

View reviewed changes

D-Brox and others added 4 commits June 15, 2022 12:32

feat(search): add file:// and warning

7cce795

fix(search,main): error/warn messages

a47b07f

Merge branch 'feat/local-repos' of https://github.com/D-Brox/pacstall …

a61cf8f

…into feat/local-repos

[pre-commit.ci] auto fixes from pre-commit.com hooks

383050c

for more information, see https://pre-commit.ci

Elsie19 requested changes Jun 15, 2022

View reviewed changes

pacstall Outdated Show resolved Hide resolved

Elsie19 changed the title ~~Feat: support for local repos~~ feat: support for local repos Jun 15, 2022

Elsie19 requested changes Jun 18, 2022

View reviewed changes

Elsie19 changed the title ~~feat: support for local repos~~ feat!: support for local repos Jun 18, 2022

fix(search): add path cases

c39339e

Elsie19 requested changes Jun 18, 2022

View reviewed changes

misc/scripts/search.sh Outdated Show resolved Hide resolved

D-Brox added 2 commits June 18, 2022 17:25

fix(search): replace backticks

7fdfc90

fix(search): replace single quotes

da031ef

Elsie19 requested changes Jun 19, 2022

View reviewed changes

fix(search): local repo formatting

7163cae

Elsie19 requested changes Jun 19, 2022

View reviewed changes

misc/scripts/download.sh Outdated Show resolved Hide resolved

Elsie19 requested changes Jun 19, 2022

View reviewed changes

D-Brox added 2 commits June 21, 2022 20:34

fix(search): add missing *, again

aa30748

chore(misc): pre-commit hooks

f116718

Elsie19 assigned D-Brox Jun 22, 2022

Elsie19 approved these changes Jun 23, 2022

View reviewed changes

wizard-28 requested changes Jun 29, 2022

View reviewed changes

misc/scripts/add-repo.sh Outdated Show resolved Hide resolved

misc/scripts/download.sh Outdated Show resolved Hide resolved

D-Brox and others added 2 commits June 29, 2022 11:07

fix(add-repo): follow redirects

2251a8f

Co-authored-by: Sourajyoti Basak <wiz28@protonmail.com>

fix(download): follow redirects

2e67184

Co-authored-by: Sourajyoti Basak <wiz28@protonmail.com>

D-Brox requested a review from wizard-28 June 29, 2022 14:08

fix(search): file:// check before github/gitlab

3baae3f

wizard-28 requested changes Jul 1, 2022

View reviewed changes

pacstall Outdated Show resolved Hide resolved

fix(main): follow redirects

8a77b05

Co-authored-by: Sourajyoti Basak <wiz28@protonmail.com>

D-Brox requested a review from wizard-28 July 2, 2022 20:09

wizard-28 requested changes Jul 4, 2022

View reviewed changes

fix(main): check file and return false

79060fe

D-Brox requested a review from wizard-28 July 4, 2022 17:46

fix(search): warn ask once

f74afbf

Elsie19 approved these changes Jul 5, 2022

View reviewed changes

wizard-28 requested changes Jul 6, 2022

View reviewed changes

fix(search): extra replace $HOME case

df77d11

D-Brox requested a review from wizard-28 July 6, 2022 15:00

wizard-28 requested changes Jul 8, 2022

View reviewed changes

D-Brox added 2 commits July 8, 2022 14:26

feat(search): link repolist.txt on supported terminals

5a95472

fix(search): suppress sed error

28024c6

D-Brox requested a review from wizard-28 July 8, 2022 17:28

wizard-28 approved these changes Jul 8, 2022

View reviewed changes

Elsie19 merged commit c996540 into pacstall:develop Jul 8, 2022

D-Brox changed the title ~~feat!: support for local repos~~ feat: support for local repos Jul 8, 2022

D-Brox deleted the feat/local-repos branch August 22, 2022 21:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support for local repos #601

feat: support for local repos #601

D-Brox commented Jun 12, 2022

Elsie19 left a comment

Elsie19 left a comment

Elsie19 left a comment

Elsie19 left a comment

Elsie19 left a comment

wizard-28 left a comment

wizard-28 left a comment

wizard-28 left a comment

feat: support for local repos #601

feat: support for local repos #601

Conversation

D-Brox commented Jun 12, 2022

Purpose

Approach

Checklist

Elsie19 left a comment

Choose a reason for hiding this comment

Elsie19 left a comment

Choose a reason for hiding this comment

Elsie19 left a comment

Choose a reason for hiding this comment

Elsie19 left a comment

Choose a reason for hiding this comment

Elsie19 left a comment

Choose a reason for hiding this comment

wizard-28 left a comment

Choose a reason for hiding this comment

wizard-28 left a comment

Choose a reason for hiding this comment

wizard-28 left a comment

Choose a reason for hiding this comment