Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in verification step of installed formula during GitHub Actions CI run #87

Closed
YOU54F opened this issue Mar 22, 2023 · 4 comments
Closed

Comments

@YOU54F
Copy link
Member

YOU54F commented Mar 22, 2023

There was some errors in the verification step when new releases are created.

See #83 (comment)

It's failing in CI, with the same error above.

I've changed to the following steps.

      - name: Verify tap (⚠️ experimental ⚠️)
        run: |
          hub checkout version/v${{ github.event.client_payload.version }}
          brew install --verbose --debug pact-ruby-standalone.rb
          brew audit --strict --online pact-ruby-standalone

I am not sure if installing the formula from the file is correct.

Once it is built, it complains that my gems aren't built correctly.

Screenshot 2023-03-22 at 18 36 21

There is also this audit issue appearing in CI

pact-ruby-standalone:
  * 2: col 3: Description is too long. It should be less than 80 characters. The current length is 94.
  * Stable: version 1.91.0 is redundant with version scanned from URL
  * Libraries were compiled with a flat namespace.
    This can cause linker errors due to name collisions, and
    is often due to a bug in detecting the macOS version.
      /opt/homebrew/Cellar/pact-ruby-standalone/1.91.0/lib/ruby/lib/libyaml-0.2.dylib

These weren't seen before, as the brew pull command has been deprecated for a couple of years.

It might be okay to merge the PR to master, but I'd like to test it out after, I was hoping I could build it locally and check it all works.

@YOU54F
Copy link
Member Author

YOU54F commented Mar 22, 2023

hmm seeing the same when just using the archive directly from the pact-ruby-standalone repo

https://github.com/pact-foundation/pact-ruby-standalone/releases/tag/v1.92.00

they are there in the downloaded tarball

image

@YOU54F
Copy link
Member Author

YOU54F commented Apr 5, 2023

Yep was an issue with the update to the json gem

@YOU54F YOU54F closed this as completed Apr 5, 2023
@YOU54F
Copy link
Member Author

YOU54F commented Apr 5, 2023

re-opening, as there is still an issue in the verification step of the tap

https://github.com/pact-foundation/homebrew-pact-ruby-standalone/actions/runs/4618323754/jobs/8165632998#step:5:7

however installed the new version and all is fine locally

Screenshot 2023-04-05 at 13 38 03

@YOU54F
Copy link
Member Author

YOU54F commented Apr 26, 2023

So errors are now being show and I've stopped it failing the build, everything seems to work in a shakedown despite the linked lib error, and its currently being used in several projects so closing

@YOU54F YOU54F closed this as completed Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant