Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when project names contain spaces #249

Open
TimothyJones opened this issue Dec 17, 2020 · 5 comments
Open

Improve error message when project names contain spaces #249

TimothyJones opened this issue Dec 17, 2020 · 5 comments

Comments

@TimothyJones
Copy link
Contributor

Similarly to #248, when the path contains a space, the ruby binaries don't work (#247). The error message is consistent and unhelpful.

We could detect this error message and recommend a fix / link to the docs.

A generic framework for detecting common errors and recommending fixes would be useful.

@mefellows
Copy link
Member

I think this is resolved now by removing Ruby.

@TimothyJones
Copy link
Contributor Author

Is Ruby removed? I thought it was still used for the CLI?

@mefellows
Copy link
Member

Yes we still expose the binstubs, but I don't think we should change the behaviour of those.

I left another issue open that leaves this possibility open, however. I'm going to remove the remaining non FFI (i.e. Ruby) wrapper code in the next major version as we no longer have any major driver to continue to support those functions.

@TimothyJones
Copy link
Contributor Author

I meant that this issue will affect the binstubs too.

I think it's really good to have the CLI wrapped in an npm package - it would be great to have that alive somehow even if they're removed from the main one.

@mefellows mefellows reopened this Aug 13, 2022
@mefellows
Copy link
Member

Ah yes, I suppose we can consider it alongside #248. I think at this moment bringing the binaries in the package is convenient (I'm not proposing we remove them), but doing anything more than that might be beyond what we should be doing here in this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants