Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: use user-configured self-signed certs in Mock Service health check #8

Open
mefellows opened this issue Nov 19, 2017 · 0 comments

Comments

@mefellows
Copy link
Member

Found https://github.com/pact-foundation/pact-node/blob/866d73eb92ca64346163389f9ac72d7e3827aec6/src/server.ts#L262-L266 as part of pact-foundation/pact-js-core#58. I assume it's been around a while, so it wasn't appropriate to add as part of that review.

I'm not sure setting this without a users' explicit permission is ever a good idea.

If people are running self-signed certificates they should either a) provide them (in the form of sslkey and sslcert) to us or b) explicitly allow an insecure connection.

My thinking here is that we should use the options.sslkey and options.sslcert in this call, or add an --insecure flag/option for this purpose.

@YOU54F YOU54F transferred this issue from pact-foundation/pact-js-core Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant