Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PSR-18 #100

Open
damianopetrungaro opened this issue Nov 5, 2018 · 2 comments
Open

Implement PSR-18 #100

damianopetrungaro opened this issue Nov 5, 2018 · 2 comments

Comments

@damianopetrungaro
Copy link

PSR 18 has been released, if you think it may be useful to include here I can open a PR to implement it.

https://www.php-fig.org/psr/psr-18/
@cfmack
Copy link
Collaborator

cfmack commented Nov 9, 2018

That's interesting. It would be helpful if Guzzle or other implementations get updated and thus require pact-php to update too. Thoughts?

@frastel
Copy link
Contributor

frastel commented Sep 17, 2019

Is there any real need for this implementation? If yes, pact-php would need a mechanism to configure the used client to profit from this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cfmack @frastel @damianopetrungaro