Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for consumer/provider names with a space. #171

Closed
siad007 opened this issue Oct 15, 2020 · 1 comment · Fixed by #172
Closed

Add support for consumer/provider names with a space. #171

siad007 opened this issue Oct 15, 2020 · 1 comment · Fixed by #172

Comments

@siad007
Copy link
Contributor

siad007 commented Oct 15, 2020

As in the given snipped, it is not easy to pass a valid consumer/provider name with a space.
For example --consumer=Foo Bar is not possible:

$results[] = "--consumer={$this->config->getConsumer()}";
$results[] = "--provider={$this->config->getProvider()}";

Before encoding it by hand or with rawurlencode, to convert the spaces to %20, we should consider to rawurlencode or maybe better escapeshellarg ❓ it right at that place.

What do you think?

@bethesque
Copy link
Member

escapeshellarg. Don't URL encode it - that's the job of the underlying HTTP client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants