Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PHPUnit to dev requirements #345

Closed
Vinimaks opened this issue Oct 5, 2023 · 2 comments
Closed

Move PHPUnit to dev requirements #345

Vinimaks opened this issue Oct 5, 2023 · 2 comments

Comments

@Vinimaks
Copy link

Vinimaks commented Oct 5, 2023

Hi there,

Currency I'm using version 8.1, where phpunit/phpunit is >=8.5.23 but I cannot update to version 9 because the version is limited < 10. Is it possible to move phpunit/phpunit to require-dev section so it can be used in projects with phpunit >= 10?

@tienvx
Copy link
Contributor

tienvx commented Oct 6, 2023

Hi @Vinimaks

I'm a contributor of version 10. From version 10 alpha, phpunit has been moved to require-dev section.

I didn't contribute to version <= 9 much so I can't tell, but from what I checked in the code, phpunit is required (https://github.com/pact-foundation/pact-php/blob/master/src/PhpPact/Consumer/Listener/PactTestListener.php), not require-dev

@YOU54F
Copy link
Member

YOU54F commented May 16, 2024

Thanks @tienvx for confirming.

@Vinimaks looks like the resolution is to move to the v10.x version, or look to backport in the release/9.x.x and update to support phpunit >= 10

That can be tracked in #338 so going to close this down

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants