Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify_wrapper.py has a bug related to headers #176

Closed
adriangabrieloros opened this issue Oct 9, 2020 · 3 comments
Closed

verify_wrapper.py has a bug related to headers #176

adriangabrieloros opened this issue Oct 9, 2020 · 3 comments

Comments

@adriangabrieloros
Copy link

the verify wrapper expects the 'custom_provider_headers' field:

headers = kwargs.get('custom_provider_headers', [])

but from the verify.py the following is sent:
'custom_provider_header': list(headers),

So it expects headers, not header.
I removed the extra 's' locally, and it works.

@elliottmurray
Copy link
Contributor

Can I just check you actually mean verifier.py not cli/verify.py?

I think you're correct and it's a bug where I changed it in one place (the verifier class was the new addition so makes sense to fix it there)

@adriangabrieloros
Copy link
Author

Yes, i confirm that.

@elliottmurray
Copy link
Contributor

#178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants